Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update log masking method #150

Merged
merged 14 commits into from
Jul 1, 2024
Merged

Update log masking method #150

merged 14 commits into from
Jul 1, 2024

Conversation

ericaporter
Copy link
Contributor

@ericaporter ericaporter commented Jun 17, 2024 •
edited
Loading

This PR includes updates to the masking hidden_pii strategy

  1. It removes masking_hidden_data method from the event_matcher as this isn't necessary for masking the logs
  2. Updates the masking method, so instead of finding the hidden_pii fields per entity, it now just searches for the hidden_pii key/values in the logs
  3. Updates to filter_matched? method to avoid exceptions

@ericaporter ericaporter requested a review from asatwal June 21, 2024 14:49
@ericaporter ericaporter self-assigned this Jun 21, 2024
asatwal
asatwal approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@asatwal asatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@ericaporter ericaporter marked this pull request as ready for review June 27, 2024 10:10
@ericaporter ericaporter merged commit ff14154 into hidden-pii-updates Jul 1, 2024
@ericaporter ericaporter deleted the debug-logging-hidden-pii branch July 1, 2024 14:10
ericaporter added a commit that referenced this pull request Jul 8, 2024
@ericaporter
Hidden pii updates (#143)
1bfd587 
* Add DATA_hidden to events table creation SQL script
* Add hidden PII required permissions to GCP custom IAM role setup instructions
* Add policy tag setup instructions to GCP setup instructions
* Update role configuration to match latest BAT configuration
* Add hidden_pii.yml (#121)
* Allow hidden data to be sent separately (#128)
* Mask hidden_pii from logs
* Add validation for hidden pii fields appearing on both lists
* Change DATA_hidden to hidden_DATA in google_cloud_bigquery_setup.md
* Change DATA_hidden to hidden_DATA in create-events-table.sql
* Cover edge cases for validations (#146)
* Update log masking method (#150)
* Add reference to hidden_pii to cutom events (#153)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asatwal asatwal asatwal approved these changes

Assignees

@ericaporter ericaporter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericaporter @asatwal