MPDX-7864 - Task phases functionailty #949
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle sizes [mpdx-react]Compared against bc5798e
|
- Pull phase data into Constants graphql - Update test wrapper to handle and report errors - Allow for more customization on common modal
…s well as fixing their tests - Updating search with new Phase data - Fixing tests in reports - Updating settings test with new Phase data - Update tools to use new phase hooks
…t status and phase data.
- Show default views if no flows saved - Reset to default views modal
- Mass actions - Task row
dr-bizz
force-pushed
the
MPDX-task-phases-new
branch
from
a8858b7
to
8016eeb
Compare
dr-bizz
changed the title
dr-bizz
added
the
On Staging
dr-bizz
added
the
Preview Environment
|
Preview branch generated at https://MPDX-task-phases-new.d3dytjb8adxkk5.amplifyapp.com |
canac
requested changes
Aug 15, 2024
There was a problem hiding this comment.
Again, great work with all of this! It's a huge undertaking.
Do you think that we should make the Task Type fields required? Otherwise, if you choose a type, touch the action field, then clear the type, you can get into a confusing state where the action is required but disabled.
| const { t } = useTranslation(); | ||
| const { openTaskModal } = useTaskModal(); | ||
| const { enqueueSnackbar } = useSnackbar(); | ||
| // TODO replace with ResultEnum when available |
There was a problem hiding this comment.
Does this TODO need to be address?
| ? activityType | ||
| : null, | ||
| changeContactStatus: false, | ||
| nextAction: null, |
There was a problem hiding this comment.
I really liked how the next action would pre-populate, since normally after sending a text, I want to make the next task another text. Is it possible to add this feature back?
There was a problem hiding this comment.
This might take some work with the new way we have it set up. Maybe we could add this back later on.
There was a problem hiding this comment.
As a user, that's disappointing, but I understand it's a post go-live improvement.
src/components/Task/Modal/Form/Complete/TaskModalCompleteForm.tsx
Outdated
Show resolved
Hide resolved
src/components/Task/Modal/Form/Complete/TaskModalCompleteForm.tsx
Outdated
Show resolved
Hide resolved
src/components/Task/Modal/Form/Complete/TaskModalCompleteForm.tsx
Outdated
Show resolved
Hide resolved
canac
reviewed
Sep 9, 2024
| }); | ||
| break; | ||
|
|
||
| case PhaseEnum.Connection: |
There was a problem hiding this comment.
I believe that the Google Doc says to open the add task modal when moving from Connections to Initiation. This will open the add task modal when moving from Connections to any other phase besides Archived. Are we sure this logic is correct?
canac
reviewed
Sep 9, 2024
Comment on lines
+9
to
+13
| accountListId: $accountListId | ||
| tasksFilter: $tasksFilter | ||
| after: $after | ||
| first: $first | ||
| sortBy: $sortBy |
There was a problem hiding this comment.
Some of these variables only have one possible value in the code. Personally, I'd hardcode them instead of making them variables in this operation. Also, $after doesn't appear to be used when calling the lazy query and can be removed.
Suggested change
| accountListId: $accountListId | |
| tasksFilter: $tasksFilter | |
| after: $after | |
| first: $first | |
| sortBy: $sortBy | |
| accountListId: $accountListId | |
| tasksFilter: $tasksFilter | |
| first: 1 | |
| sortBy: "START_AT_ASC" |
The message is shown in task modal that open as a result of a contact's status changing in flows view
[MPDX-8176] Add message to task modals in flows view
[MPDX-8175] Tweak reset flows warning message
* Rename Referral to Connection * Rename function for filters panel
* Use correctly formatted partner status name on reports * Use correctly formatted/translated Phase in modals
* Make the Result field an autocomplete * Make the Reminders fields Autocomplete * Add autoSelect
* Rename email newsletter to Digital
dr-bizz
commented
Sep 17, 2024
| @@ -8,7 +8,7 @@ on: | |||
|
|
|||
| env: | |||
| # Use production API for codegen to make sure production is compatible with the code to be merged | |||
| API_URL: 'https://api.mpdx.org/graphql' | |||
| API_URL: 'https://api.stage.mpdx.org/graphql' | |||
There was a problem hiding this comment.
Make sure we revert this before going live. I know I have a commit on this. But putting it in multiple places.
| @@ -62,6 +75,7 @@ const getAccountListAnalytics = (data: { | |||
| text_message, | |||
| start_date: startDate, | |||
| end_date: endDate, | |||
| contacts_by_status, | |||
There was a problem hiding this comment.
Suggested change
| contacts_by_status, | |
| contacts_by_status: contactsByStatus, |
src/components/Coaching/CoachingDetail/ActivitySummary/ActivitySummary.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request integrates the Task phases functionality into the MPDX application. The update encompasses several areas, including task initialization, contact management, and coaching updates.
Authors: @caleballdrin & @dr-bizz
Detailed Changes
Initialization
Contacts
Tasks
Coaching
Testing
Note on Branch Change
Due to the high number of commits (140) on the previous branch "MPDX-task-phases" and the resulting merge conflicts from multiple code changes, I had to move to a new branch "MPDX-task-phases-new." This new branch was created to make it easier to create and review new commits without the complexities of resolving numerous conflicts.
This approach should provide a clearer and more manageable review process.
Checklist: