Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-8169 Rename to Digital Newsletter #1062

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

caleballdrin
Copy link
Contributor

Description

https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-8169&sprint=1259#

  • Rename Email Newsletter to Digital Newsletter

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@caleballdrin caleballdrin self-assigned this Sep 11, 2024
@caleballdrin caleballdrin added the Preview Environment Add this label to create an Amplify Preview label Sep 11, 2024
Copy link

Preview branch generated at https://MPDX-8169-rename-newsletter.d3dytjb8adxkk5.amplifyapp.com

Copy link

github-actions bot commented Sep 11, 2024

Bundle sizes [mpdx-react]

Compared against d8322b7

Route Size (gzipped) Diff
/_app 372.62 KB +1.15 KB
/accountLists 118.83 KB -1.67 KB
/accountLists/[accountListId] 271.03 KB -1014 B
/accountLists/[accountListId]/coaching/[coachingId] 247.47 KB +1.23 KB
/accountLists/[accountListId]/contacts/[[...contactId]] 104.14 KB -1.67 KB
/accountLists/[accountListId]/contacts/flows/setup 178.71 KB +30.97 KB
/accountLists/[accountListId]/reports/coaching 247.48 KB +1.23 KB
/accountLists/[accountListId]/reports/donations/[[...contactId]] 343.91 KB -2.55 KB
/accountLists/[accountListId]/reports/expectedMonthlyTotal 109.79 KB +1.16 KB
/accountLists/[accountListId]/reports/partnerGivingAnalysis/[[...contactId]] 131.82 KB -1.04 KB
/accountLists/[accountListId]/settings/admin 134.11 KB -1.76 KB
/accountLists/[accountListId]/settings/integrations 153.94 KB -9.8 KB
/accountLists/[accountListId]/settings/manageAccounts 141.63 KB -2.73 KB
/accountLists/[accountListId]/settings/manageCoaches 138.18 KB -1.95 KB
/accountLists/[accountListId]/settings/notifications 134.94 KB -2.57 KB
/accountLists/[accountListId]/settings/organizations 135.96 KB -1.74 KB
/accountLists/[accountListId]/settings/organizations/accountLists 132.03 KB -7.36 KB
/accountLists/[accountListId]/settings/organizations/contacts 130.84 KB -5.34 KB
/accountLists/[accountListId]/settings/preferences 209.47 KB -4.06 KB
/accountLists/[accountListId]/tools 114.54 KB -28.69 KB
/accountLists/[accountListId]/tools/appeals 159.73 KB -26.55 KB
/accountLists/[accountListId]/tools/appeals/[appealId] 178.96 KB added
/accountLists/[accountListId]/tools/fixCommitmentInfo 91.75 KB added
/accountLists/[accountListId]/tools/fixEmailAddresses 89.92 KB added
/accountLists/[accountListId]/tools/fixMailingAddresses 92.78 KB added
/accountLists/[accountListId]/tools/fixPhoneNumbers 90.23 KB added
/accountLists/[accountListId]/tools/fixSendNewsletter 88.76 KB added
/accountLists/[accountListId]/tools/mergeContacts 87.83 KB added
/accountLists/[accountListId]/tools/mergePeople 86.61 KB added
/login 118.89 KB -1.51 KB
/accountLists/[accountListId]/setup/finish no change removed
/accountLists/[accountListId]/tools/appeals/appeal/[[...appealId]] no change removed
/accountLists/[accountListId]/tools/fix/commitmentInfo/[[...contactId]] no change removed
/accountLists/[accountListId]/tools/fix/emailAddresses/[[...contactId]] no change removed
/accountLists/[accountListId]/tools/fix/mailingAddresses/[[...contactId]] no change removed
/accountLists/[accountListId]/tools/fix/phoneNumbers/[[...contactId]] no change removed
/accountLists/[accountListId]/tools/fix/sendNewsletter/[[...contactId]] no change removed
/accountLists/[accountListId]/tools/import/csv no change removed
/accountLists/[accountListId]/tools/import/google no change removed
/accountLists/[accountListId]/tools/import/tnt no change removed
/accountLists/[accountListId]/tools/merge/contacts/[[...contactId]] no change removed
/accountLists/[accountListId]/tools/merge/people/[[...contactId]] no change removed
/setup/account no change removed
/setup/connect no change removed
/setup/start no change removed
Dynamic import Size (gzipped) Diff
../src/components/Contacts/ContactDetails/ContactDetailsTab/DynamicContactDetailsTab.tsx -> ./ContactDetailsTab 62.62 KB -4.09 KB
../src/components/Contacts/ContactFlow/DynamicContactFlow.tsx -> ./ContactFlow 47.22 KB -13.79 KB
../src/components/Contacts/ContactsList/DynamicContactsList.tsx -> ./ContactsList 29.51 KB -13.34 KB
../src/components/Contacts/ContactsMap/DynamicContactsMap.tsx -> ./ContactsMap 32.4 KB +1.65 KB
../src/components/Contacts/ContactsMap/DynamicContactsMapPanel.tsx -> ./ContactsMapPanel 8.07 KB +1.83 KB
../src/components/Contacts/ContactsRightPanel/DynamicContactsRightPanel.tsx -> ./ContactsRightPanel 135.51 KB -6.02 KB
../src/components/Contacts/MassActions/Exports/Emails/DynamicMassActionsExportEmailsModal.tsx -> ./MassActionsExportEmailsModal 1.94 KB -1.15 KB
../src/components/Layouts/Primary/TopBar/Items/AddMenu/Items/CreateMultipleContacts/DynamicCreateMultipleContacts.tsx -> ./CreateMultipleContacts 78.2 KB +3.07 KB
../src/components/Layouts/Primary/TopBar/Items/SearchMenu/DynamicSearchDialog.tsx -> ./SearchDialog 16.9 KB +1.04 KB
../src/components/Shared/Filters/DynamicFilterPanel.tsx -> ./FilterPanel 101.55 KB -3.98 KB
../src/components/Task/Modal/Form/Complete/DynamicTaskModalCompleteForm.tsx -> ./TaskModalCompleteForm 112.17 KB +13.51 KB
../src/components/Task/Modal/Form/DynamicTaskModalForm.tsx -> ./TaskModalForm 120.93 KB +14.41 KB
../src/components/Task/Modal/Form/LogForm/DynamicTaskModalLogForm.tsx -> ./TaskModalLogForm 151.55 KB +11.44 KB
../src/components/Contacts/ContactDetails/ContactDetailsTab/Mailing/AddAddressModal/DynamicAddAddressModal.tsx -> ./AddAddressModal no change removed
../src/components/Contacts/ContactDetails/ContactDetailsTab/Mailing/EditContactAddressModal/DynamicEditContactAddressModal.tsx -> ./EditContactAddressModal no change removed
../src/components/Tool/Appeal/Flow/DynamicContactFlow.tsx -> ./ContactFlow no change removed
../src/components/Tool/Appeal/List/AppealTour/DynamicAppealTour.tsx -> ./AppealTour no change removed
../src/components/Tool/Appeal/List/AppealsListFilterPanel/DynamicAppealsListFilterPanel.tsx -> ./AppealsListFilterPanel no change removed
../src/components/Tool/Appeal/List/ContactsList/DynamicContactsList.tsx -> ./ContactsList no change removed
../src/components/Tool/Appeal/Modals/AddContactToAppealModal/DynamicAddContactToAppealModal.tsx -> ./AddContactToAppealModal no change removed
../src/components/Tool/Appeal/Modals/AddExcludedContactModal/DynamicAddExcludedContactModal.tsx -> ./AddExcludedContactModal no change removed
../src/components/Tool/Appeal/Modals/DeleteAppealContact/DynamicDeleteAppealContactModal.tsx -> ./DeleteAppealContactModal no change removed
../src/components/Tool/Appeal/Modals/DeleteAppealModal/DynamicDeleteAppealModal.tsx -> ./DeleteAppealModal no change removed
../src/components/Tool/Appeal/Modals/DeletePledgeModal/DynamicDeletePledgeModal.tsx -> ./DeletePledgeModal no change removed
../src/components/Tool/Appeal/Modals/EditAppealHeaderInfoModal/DynamicEditAppealHeaderInfoModal.tsx -> ./EditAppealHeaderInfoModal no change removed
../src/components/Tool/Appeal/Modals/PledgeModal/DynamicPledgeModal.tsx -> ./PledgeModal no change removed
../src/components/Tool/Appeal/Modals/UpdateDonationsModal/DynamicUpdateDonationsModal.tsx -> ./UpdateDonationsModal no change removed
../src/components/Tool/Import/Csv/DynamicCsvHeaders.tsx -> ./CsvHeaders no change removed
../src/components/Tool/Import/Csv/DynamicCsvPreview.tsx -> ./CsvPreview no change removed
../src/components/Tool/Import/Csv/DynamicCsvUpload.tsx -> ./CsvUpload no change removed
../src/components/Tool/Import/Csv/DynamicCsvValues.tsx -> ./CsvValues no change removed

Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Do you think this one needs changed too?

message = t(
'On your email newsletter list but has no people with a valid email address',
);

@caleballdrin caleballdrin merged commit fd573ee into MPDX-task-phases-new Sep 12, 2024
18 checks passed
@caleballdrin caleballdrin deleted the MPDX-8169-rename-newsletter branch September 12, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants