Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPDX-8175] Tweak reset flows warning message #1041

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Sep 9, 2024

Description

Is this what we had in mind? I forgot that we already had a warning message. I made the warning it a little bit more explicit, but I'm definitely open to suggestions.

Before:

Screenshot 2024-09-09 at 2 39 49 PM

After:

Screenshot 2024-09-09 at 2 40 07 PM

MPDX-8175

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

Copy link

github-actions bot commented Sep 9, 2024

Bundle sizes [mpdx-react]

Compared against 8460733

Route Size (gzipped) Diff
/accountLists 118.85 KB -1.66 KB
/accountLists/[accountListId]/coaching/[coachingId] 247.49 KB +1.25 KB
/accountLists/[accountListId]/contacts/[[...contactId]] 104.15 KB -1.66 KB
/accountLists/[accountListId]/contacts/flows/setup 178.86 KB +31.12 KB
/accountLists/[accountListId]/reports/coaching 247.5 KB +1.25 KB
/accountLists/[accountListId]/reports/donations/[[...contactId]] 343.86 KB -2.6 KB
/accountLists/[accountListId]/reports/partnerGivingAnalysis/[[...contactId]] 131.77 KB -1.09 KB
/accountLists/[accountListId]/settings/admin 134.06 KB -1.81 KB
/accountLists/[accountListId]/settings/integrations 153.89 KB -9.85 KB
/accountLists/[accountListId]/settings/manageAccounts 141.59 KB -2.77 KB
/accountLists/[accountListId]/settings/manageCoaches 138.14 KB -2 KB
/accountLists/[accountListId]/settings/notifications 134.89 KB -2.62 KB
/accountLists/[accountListId]/settings/organizations 135.92 KB -1.79 KB
/accountLists/[accountListId]/settings/organizations/accountLists 131.98 KB -7.41 KB
/accountLists/[accountListId]/settings/organizations/contacts 130.79 KB -5.39 KB
/accountLists/[accountListId]/settings/preferences 210.29 KB -3.24 KB
/accountLists/[accountListId]/tasks/[[...contactId]] 139.51 KB +1.75 KB
/accountLists/[accountListId]/tools 114.56 KB -28.61 KB
/accountLists/[accountListId]/tools/appeals 159.75 KB -26.15 KB
/accountLists/[accountListId]/tools/appeals/[appealId] 178.97 KB added
/accountLists/[accountListId]/tools/fixCommitmentInfo 91.77 KB added
/accountLists/[accountListId]/tools/fixEmailAddresses 89.93 KB added
/accountLists/[accountListId]/tools/fixMailingAddresses 92.8 KB added
/accountLists/[accountListId]/tools/fixPhoneNumbers 90.25 KB added
/accountLists/[accountListId]/tools/fixSendNewsletter 88.78 KB added
/accountLists/[accountListId]/tools/mergeContacts 87.84 KB added
/accountLists/[accountListId]/tools/mergePeople 86.62 KB added
/login 118.91 KB -1.49 KB
/accountLists/[accountListId]/setup/finish no change removed
/accountLists/[accountListId]/tools/appeals/appeal/[[...appealId]] no change removed
/accountLists/[accountListId]/tools/fix/commitmentInfo/[[...contactId]] no change removed
/accountLists/[accountListId]/tools/fix/emailAddresses/[[...contactId]] no change removed
/accountLists/[accountListId]/tools/fix/mailingAddresses/[[...contactId]] no change removed
/accountLists/[accountListId]/tools/fix/phoneNumbers/[[...contactId]] no change removed
/accountLists/[accountListId]/tools/fix/sendNewsletter/[[...contactId]] no change removed
/accountLists/[accountListId]/tools/import/csv no change removed
/accountLists/[accountListId]/tools/import/google no change removed
/accountLists/[accountListId]/tools/import/tnt no change removed
/accountLists/[accountListId]/tools/merge/contacts/[[...contactId]] no change removed
/accountLists/[accountListId]/tools/merge/people/[[...contactId]] no change removed
/setup/account no change removed
/setup/connect no change removed
/setup/start no change removed
Dynamic import Size (gzipped) Diff
../src/components/Contacts/ContactDetails/ContactDetailsTab/DynamicContactDetailsTab.tsx -> ./ContactDetailsTab 62.65 KB -4.06 KB
../src/components/Contacts/ContactFlow/DynamicContactFlow.tsx -> ./ContactFlow 47.36 KB -13.48 KB
../src/components/Contacts/ContactsList/DynamicContactsList.tsx -> ./ContactsList 30.3 KB -12.51 KB
../src/components/Contacts/ContactsMap/DynamicContactsMap.tsx -> ./ContactsMap 32.4 KB +1.65 KB
../src/components/Contacts/ContactsMap/DynamicContactsMapPanel.tsx -> ./ContactsMapPanel 8.07 KB +1.83 KB
../src/components/Contacts/ContactsRightPanel/DynamicContactsRightPanel.tsx -> ./ContactsRightPanel 137.34 KB -4.2 KB
../src/components/Contacts/MassActions/Exports/Emails/DynamicMassActionsExportEmailsModal.tsx -> ./MassActionsExportEmailsModal 1.94 KB -1.16 KB
../src/components/EditDonationModal/DynamicEditDonationModal.tsx -> ./EditDonationModal 75.45 KB +1.34 KB
../src/components/Layouts/Primary/TopBar/Items/AddMenu/Items/CreateMultipleContacts/DynamicCreateMultipleContacts.tsx -> ./CreateMultipleContacts 78.03 KB +2.9 KB
../src/components/Layouts/Primary/TopBar/Items/SearchMenu/DynamicSearchDialog.tsx -> ./SearchDialog 16.9 KB +1.04 KB
../src/components/Shared/Filters/DynamicFilterPanel.tsx -> ./FilterPanel 101.5 KB -4.04 KB
../src/components/Task/Modal/Form/Complete/DynamicTaskModalCompleteForm.tsx -> ./TaskModalCompleteForm 110.94 KB +12.28 KB
../src/components/Task/Modal/Form/DynamicTaskModalForm.tsx -> ./TaskModalForm 121.76 KB +15.24 KB
../src/components/Task/Modal/Form/LogForm/DynamicTaskModalLogForm.tsx -> ./TaskModalLogForm 150.53 KB +10.42 KB
../src/components/Contacts/ContactDetails/ContactDetailsTab/Mailing/AddAddressModal/DynamicAddAddressModal.tsx -> ./AddAddressModal no change removed
../src/components/Contacts/ContactDetails/ContactDetailsTab/Mailing/EditContactAddressModal/DynamicEditContactAddressModal.tsx -> ./EditContactAddressModal no change removed
../src/components/Tool/Appeal/Flow/DynamicContactFlow.tsx -> ./ContactFlow no change removed
../src/components/Tool/Appeal/List/AppealTour/DynamicAppealTour.tsx -> ./AppealTour no change removed
../src/components/Tool/Appeal/List/AppealsListFilterPanel/DynamicAppealsListFilterPanel.tsx -> ./AppealsListFilterPanel no change removed
../src/components/Tool/Appeal/List/ContactsList/DynamicContactsList.tsx -> ./ContactsList no change removed
../src/components/Tool/Appeal/Modals/AddContactToAppealModal/DynamicAddContactToAppealModal.tsx -> ./AddContactToAppealModal no change removed
../src/components/Tool/Appeal/Modals/AddExcludedContactModal/DynamicAddExcludedContactModal.tsx -> ./AddExcludedContactModal no change removed
../src/components/Tool/Appeal/Modals/DeleteAppealContact/DynamicDeleteAppealContactModal.tsx -> ./DeleteAppealContactModal no change removed
../src/components/Tool/Appeal/Modals/DeleteAppealModal/DynamicDeleteAppealModal.tsx -> ./DeleteAppealModal no change removed
../src/components/Tool/Appeal/Modals/DeletePledgeModal/DynamicDeletePledgeModal.tsx -> ./DeletePledgeModal no change removed
../src/components/Tool/Appeal/Modals/EditAppealHeaderInfoModal/DynamicEditAppealHeaderInfoModal.tsx -> ./EditAppealHeaderInfoModal no change removed
../src/components/Tool/Appeal/Modals/PledgeModal/DynamicPledgeModal.tsx -> ./PledgeModal no change removed
../src/components/Tool/Appeal/Modals/UpdateDonationsModal/DynamicUpdateDonationsModal.tsx -> ./UpdateDonationsModal no change removed
../src/components/Tool/Import/Csv/DynamicCsvHeaders.tsx -> ./CsvHeaders no change removed
../src/components/Tool/Import/Csv/DynamicCsvPreview.tsx -> ./CsvPreview no change removed
../src/components/Tool/Import/Csv/DynamicCsvUpload.tsx -> ./CsvUpload no change removed
../src/components/Tool/Import/Csv/DynamicCsvValues.tsx -> ./CsvValues no change removed

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that wording sounds good.

@canac canac merged commit 0f2c06b into MPDX-task-phases-new Sep 10, 2024
16 checks passed
@canac canac deleted the 8175-reset-flows-warning branch September 10, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants