Ionization: update barrier suppression and energies #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge #1021 before this pull request! |
|
@ax3l @psychocoderHPC |
|
Pls help us by commiting the
-> all files (reference file and examples) catched 👍 |
|
@n01r pls rebase before we start commenting inline (rebase will hide/loose the comments) |
n01r
force-pushed
the
topic-updateBarrierSuppressionAndEnergies
branch
from
d6256f9
to
9edc173
Compare
added 4 commits
August 10, 2015 13:17
- `speciesDefinition.param`: only updated in the LWFA example to use the
new ionization energy table
- `physicalConstants.param`: atomic unit constants for energy, e-field and
time added (default used in examples);
also added unit conversions between eV and AU
to allow for input in `ionizationEnergies.param`
- `physicalConstants.unitless`: `ATOMIC_UNIT_EFIELD` and `ATOMIC_UNIT_TIME`
-> conversion from PIConGPU units to AU;
examples and reference file updated
- `speciesAttributes.param`: new alias for ionizationEnergies table added
(default used in examples)
- `ionizationEnergies.param`,
`ionizerConfig.param`,
`ionizerConfig.unitless`: reference files update (default used in examples)
Similar to the trait `GetAtomicNumbers` the ionization potentials can now be accessed if they have been defined for the species in a flag.
All references to the files where each ionization model is calculated
have been collected in two new files:
- `fieldIonizationCalc.def`
- `fieldIonizationCalc.hpp`
and forward declarations are made in the `.def` file.
- `AlgorithmBSI.hpp`: use field from AU namespace - `BSI.def`, `BSI_Impl`: changes in documentation
n01r
force-pushed
the
topic-updateBarrierSuppressionAndEnergies
branch
from
9edc173
to
4ec5cc8
Compare
|
@ax3l Here you go! |
|
very well done, thx! ✨ |
ax3l
added a commit
that referenced
this pull request
Aug 10, 2015
…nergies Ionization: update barrier suppression and energies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the upcoming ADK model, some of the non-model related changes have been removed from #922 to be implemented before.
This pull request features:
Should be merged before #922!
fix traitsis merged and rebaseGetUniqueTypeId#1021