Add ionization model ADK #922

n01r · 2015-06-11T12:57:17Z

Added the first tunneling ionization model to PIConGPU.
It should be used on hydrogen-like atoms and ions and requires a random generator because it uses a Monte-Carlo method.

~~Do not merge before #874~~

Feel free to also point out ideas for optimization and better handling of the random numbers.

Only the last commits after f030d45 ( "Small fixes pointed out by @PrometheusPi" ) are new ~~while the rest before is from #874~~.

Update:

wait till ~~Ionization: update barrier suppression and energies #1022~~ is merged

n01r · 2015-06-11T13:02:28Z

Again, keep in mind: you only need to check the files commit-wise from the last commits. Otherwise you will see the changes from #874, too.

ax3l · 2015-06-18T09:09:40Z

@n01r pls rebase against dev :)

Do you add the "add list of ionization methods (instead of single selection) applied to a species" before or after this pull?

n01r · 2015-06-18T09:25:59Z

I would say: after. Makes more sense if we already have two models that I can test and see if I can avoid double counting and so on. It also makes more sense chronologically:
Add ionization model 1, see that it is unphysical.
Add ionization model 2, see that it becomes unphysical at high field strengths,
Get the idea that combining the two might make it a bit less wrong.

ADK is practically ready anyway except from what you guys might have to remark about it.
I'll open an issue for the consecutive-ionization-model implementation.

ax3l · 2015-06-18T10:06:56Z

sounds reasonable, all right.

n01r · 2015-06-18T13:01:50Z

@ax3l
Did the rebase just now ... although I can still see the old commits - strange.
Ah I'll just do a git reset --soft HEAD~<number of commits> then

ax3l · 2015-06-18T21:37:05Z

during git rebase -i dev, just remove the lines of the old (now duplicated) commits as they show up in your editor: in that case they are really dropped from the branch's commit history.

ax3l · 2015-06-18T21:42:57Z

src/picongpu/include/simulation_defines/param/ionizationEnergies.param

+    /* atomic unit for energy:
+     * 1 Rydberg = 27.21 eV --> converted to Joule
+     */
+    const float_X ATOMIC_UNIT_ENERGY = 4.36e-18;


the values here must be float_64 if in SI and they should be normalized in a ionizationEnergies.unitless file before being used in the code.

ah - alright, I was doing that in the AlgorithmADK.hpp
but sure it would be clever to do the normalization there

ax3l · 2015-06-22T16:04:17Z

examples/LaserWakefield/include/simulation_defines/param/speciesDefinition.param

@@ -141,7 +141,7 @@ typedef bmpl::vector<
    interpolation<UsedField2Particle>,
    current<UsedParticleCurrentSolver>,
    #if(PARAM_IONIZATION == 1)
-    ionizer<particles::ionization::BSI<PIC_Electrons> >,
+    ionizer<particles::ionization::ADK<PIC_Electrons> >,


do you really want to use ADK by default if it still a bit slow?

sorry, forgot that - will change it back

psychocoderHPC · 2015-08-05T15:47:06Z

src/picongpu/include/particles/ionization/byField/ADK/ADK_Impl.hpp

+                IonizationAlgorithm ionizeAlgo;
+                ionizeAlgo(
+                     bField, eField,
+                     particle, (float_X)RandomGen()


please use static_cast<float_X> or precisionCast<float_X>

don't need to - I overlooked that the operator() returns float_X already

n01r · 2015-08-06T09:03:26Z

Seems like I have to do another rebase after all the changes in dev and some squashes before final merging after I fix the issues.

ax3l · 2015-08-10T11:49:45Z

💃 rebase me, yeah yeah yeah 🎶

psychocoderHPC · 2015-08-14T12:26:35Z

src/picongpu/include/particles/ionization/byField/ADK/ADK_Impl.hpp

+                          cachedE,
+                          fieldEBlock
+                          );
+


please call __syncthreads(); heare to be sure that the shared memory operation before are finished.

added below

psychocoderHPC · 2015-08-27T08:19:43Z

src/picongpu/include/particles/ionization/ionizationMethods.hpp

+             * Omitting this results in the different GPUs receiving the same set of seeds
+             * periodically where the period is the max. number of MPI ranks.
+             */
+            seed=seed<<16;


After #1046 is merged please remove this workaround.

@n01r now merged, pls rebase and remove the work-around

Random number generation has been included.

A simplified version of the Ammosov-Delone-Krainov tunneling ionization model has been added. It is valid for hydrogen and hydrogenlike atoms.

- `ionization.hpp`: Add documentation to clarify the domain coordinates - `ionizationMehtods.hpp`: Use the correct cell index inside the local domain to improve seeding. Also added documentation. Shift the unique bits per GPU and species to the left before XORing with `currentStep` and `IONIZATION_SEED` to avoid losing uniqueness.

The random number generator only needs the cell coordinate in the local domain. This parameter was already passed to the RNG but named wrongly. Also: added another `__syncthreads()` in `ADK_Impl.hpp`

- `ionizationMethods.hpp`: - Removed workaround for good seed after merge of ComputationalRadiationPhysics#1046 - `utilities.hpp`: - Added EOF newline

n01r · 2015-08-28T10:04:01Z

@ax3l I removed the workaround, added an EOF newline where necessary, rebased, compiled, run-tested and re-pushed.

ax3l · 2015-08-28T13:26:03Z

great, thx! ✨

ax3l · 2015-08-28T13:28:14Z

examples/LaserWakefield/include/simulation_defines/param/speciesDefinition.param

@@ -140,6 +140,7 @@ struct Hydrogen
 * For development purposes: ---------------------------------------------


this comment needs to be added to the general src/picongpu/include/simulation_defines/param/speciesDefinition.param file - but we can postpone this until ionization leaves the in development state.

Add ionization model ADK

psychocoderHPC · 2016-08-29T11:15:02Z

src/picongpu/include/particles/ionization/byField/ADK/ADK_Impl.hpp

+            UpperMargin
+            > BlockArea;
+
+        BlockArea BlockDescription;


@ax3l Who checked this branch last year? ^^

This is not used. This is also in the current version.

not used "any more" ;)
there was probably a magical state in between we can't see ^^

n01r changed the title ~~Ionization model ADK~~ Add ionization model ADK Jun 11, 2015

PrometheusPi added the feature label Jun 11, 2015

PrometheusPi added this to the Open Beta milestone Jun 11, 2015

PrometheusPi added the wait-4-author/WIP label Jun 11, 2015

ax3l self-assigned this Jun 17, 2015

n01r force-pushed the topic-ionizationModelADK branch from 74a34b7 to c97949b Compare June 18, 2015 13:01

ax3l reviewed Jun 18, 2015
View reviewed changes

n01r force-pushed the topic-ionizationModelADK branch 3 times, most recently from 8eb3fc1 to f9b05ad Compare June 22, 2015 13:58

ax3l removed the wait-4-author/WIP label Jun 22, 2015

ax3l reviewed Jun 22, 2015
View reviewed changes

psychocoderHPC reviewed Aug 5, 2015
View reviewed changes

n01r mentioned this pull request Aug 6, 2015

Ionization: update barrier suppression and energies #1022

Merged

1 task

n01r force-pushed the topic-ionizationModelADK branch from 3b326be to 58b6b78 Compare August 6, 2015 15:30

n01r force-pushed the topic-ionizationModelADK branch 2 times, most recently from 97c627a to 01c3479 Compare August 13, 2015 12:47

psychocoderHPC reviewed Aug 14, 2015
View reviewed changes

n01r mentioned this pull request Aug 14, 2015

Fix: missing __syncthreads() after shared mem usage #1048

Merged

ax3l removed the wait-4-author/WIP label Aug 17, 2015

psychocoderHPC reviewed Aug 27, 2015
View reviewed changes

Marco Garten added 6 commits August 27, 2015 17:40

Prepare for adding of Monte-Carlo-based model

93b98ea

Random number generation has been included.

Add new ionization model ADK

3906eb3

A simplified version of the Ammosov-Delone-Krainov tunneling ionization model has been added. It is valid for hydrogen and hydrogenlike atoms.

Aligned the E- and B-field boxes

d58b450

Rename totalCellOffset --> localCellOffset

236bc03

The random number generator only needs the cell coordinate in the local domain. This parameter was already passed to the RNG but named wrongly. Also: added another `__syncthreads()` in `ADK_Impl.hpp`

Remove workaround for seed, add EOF newline

86fc053

- `ionizationMethods.hpp`: - Removed workaround for good seed after merge of ComputationalRadiationPhysics#1046 - `utilities.hpp`: - Added EOF newline

n01r force-pushed the topic-ionizationModelADK branch from c3d0b26 to 86fc053 Compare August 28, 2015 10:02

ax3l added component: core in PIConGPU (core application) and removed component: core in PIConGPU (core application) labels Aug 28, 2015

ax3l reviewed Aug 28, 2015
View reviewed changes

ax3l added a commit that referenced this pull request Aug 28, 2015

Merge pull request #922 from n01r/topic-ionizationModelADK

9a8cc03

Add ionization model ADK

ax3l merged commit 9a8cc03 into ComputationalRadiationPhysics:dev Aug 28, 2015

n01r deleted the topic-ionizationModelADK branch August 28, 2015 13:48

psychocoderHPC reviewed Aug 29, 2016
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ionization model ADK #922

Add ionization model ADK #922

n01r commented Jun 11, 2015

n01r commented Jun 11, 2015

ax3l commented Jun 18, 2015

n01r commented Jun 18, 2015

ax3l commented Jun 18, 2015

n01r commented Jun 18, 2015

ax3l commented Jun 18, 2015

ax3l Jun 18, 2015

n01r Jun 19, 2015

ax3l Jun 22, 2015

n01r Jun 22, 2015

ax3l Jun 22, 2015

psychocoderHPC Aug 5, 2015

n01r Aug 6, 2015

n01r commented Aug 6, 2015

ax3l commented Aug 10, 2015

psychocoderHPC Aug 14, 2015

ax3l Aug 27, 2015

psychocoderHPC Aug 27, 2015

ax3l Aug 27, 2015

n01r commented Aug 28, 2015

ax3l commented Aug 28, 2015

ax3l Aug 28, 2015

psychocoderHPC Aug 29, 2016

ax3l Aug 29, 2016 •

edited

Loading

		@@ -140,6 +140,7 @@ struct Hydrogen
		* For development purposes: ---------------------------------------------

Add ionization model ADK #922

Add ionization model ADK #922

Conversation

n01r commented Jun 11, 2015

n01r commented Jun 11, 2015

ax3l commented Jun 18, 2015

n01r commented Jun 18, 2015

ax3l commented Jun 18, 2015

n01r commented Jun 18, 2015

ax3l commented Jun 18, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

n01r commented Aug 6, 2015

ax3l commented Aug 10, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

n01r commented Aug 28, 2015

ax3l commented Aug 28, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ax3l Aug 29, 2016 • edited Loading

Choose a reason for hiding this comment

ax3l Aug 29, 2016 •

edited

Loading