fix traits GetUniqueTypeId

[psychocoderHPC]

• assert in getUniqueTypeId is triggert with a special environment on hypnos
• baseUId is not smallest created id

fix:

• explicit initialize the base TypeId with GetUniqueTypeId<uint8_t>::byte
• remove pointer address magic
• add base type with static global counter
• add boost::numeric::bounds for max value calculation

Environment:

module load gcc/4.8.2
module load cmake/3.0.1
module load cuda/6.5
module load openmpi/1.8.4.kepler
module load boost/1.54.0

# Plugins (optional)
module load pngwriter/0.5.4
module load hdf5-parallel/1.8.14 libsplash/1.2.4
module load numactl/2.0.7
module load paraview/3.98.laser
module load svn
module load gnuplot/4.2.6

Tested with:

• gnu 4.8.2
• llvm/3.4
• pgi/15.5
• intel/2015.3.187
• gnu 4.8.2 (on 4 nodes with mpiexec)

[BenjaminW3]

I have seen this coming 😄

Currently you specialize the uint8_t case, which is equal to the base id, to be equal to zero. What is then left of the purpose of the base id subtraction? Could we fully remove this subraction?

[n01r]

Thanks, though - worked for me!

[psychocoderHPC]

@BenjaminW3 If have changed the algorithm to create IDs. Now it is a counter based on the some method like before. Every time a compiler sees a new type the id of the base type is incremented and stored in the new type.

[BenjaminW3]

In the current version the <iostream> and <cassert> headers can be removed.

[psychocoderHPC]

I removed the not used includes and add some missing one.

[BenjaminW3]

While testing this header in isolation I found that std::runtime_error is defined in <stdexcept> and not in <exception>.
Could you additionally add the missing #include <climits> for CHAR_BIT?

[psychocoderHPC]

Yes we should add both includes, thx

[psychocoderHPC]

removed bit magic calculation for maxValue with boost::numeric::bounds<ResultType>::highest

@ax3l do you know how I can check in which library boost::numeric::bounds is defined?

• check if boost::numeric::bounds<> is part of the boost components that are set as required in CMakeLists.txt -> current components program_options regex filesystem system

[psychocoderHPC]

boost::numeric::bounds looks like header only. I checked all boost libraries for a symbol highest and found nothing.

[ax3l]

@psychocoderHPC yes it's part of Boost.NumericConversion and header only. I added links in the description and your last comment.

I also have a gist for exactly that question because there is actually a large list which is not header-only.

thank you for taking good care when introducing new libraries, perfect! 🚀

[ax3l]

@BenjaminW3

I have seen this coming 😄

^^ me too. good we added asserts!