Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix roll_remainder eoc effect #79526

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix roll_remainder eoc effect #79526

merged 1 commit into from
Feb 4, 2025

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

Fix #79524

Describe the solution

move "message" effect below so it is read later

Testing

Copypasted one of the eocs in #79460, doesn't load
Made the change, now it loads

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 3, 2025
@Maleclypse Maleclypse merged commit fcaebb3 into master Feb 4, 2025
29 checks passed
@GuardianDll GuardianDll deleted the fix_msg branch February 4, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The message field in u_roll_remainer does not actually work
2 participants