Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The message field in u_roll_remainer does not actually work #79524

Closed
Standing-Storm opened this issue Feb 3, 2025 · 0 comments · Fixed by #79526
Closed

The message field in u_roll_remainer does not actually work #79524

Standing-Storm opened this issue Feb 3, 2025 · 0 comments · Fixed by #79526
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@Standing-Storm
Copy link
Contributor

Describe the bug

The u_roll_remainder documentation mentions a message field that allows the game to explain what was rolled when a recipe, spell, etc is granted to the player. However, attempting to use this field causes hallucinatory JSON errors (like claiming that u_roll_remainder itself is invalid).

Attach save file

N/A, occurs on load (and requires JSON modification)

Steps to reproduce

  1. Place the following JSON somewhere in your data so it loads:
{
    "type": "effect_on_condition",
    "id": "EOC_ROLL_REMAINDER_MESSAGE_DOES_NOT_WORK",
    "effect": [
      {
        "u_roll_remainder": [ "STR_UP" ],
        "type": "mutation",
        "message": "You got a mutation!  Those gainz",
        "true_eocs": [ "EOC_NONE" ],
        "false_eocs": [ "EOC_NONE" ]
      }
    ]
  }
  1. Attempt to load the game.
  2. Hallucinatory JSON errors

Expected behavior

The message field functions as described in the u_roll_remainder documentation.

Screenshots

Image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.22631.4751 (23H2)
  • Game Version: cdda-experimental-2025-02-03-0802 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth]
    ]

Additional context

No response

@Standing-Storm Standing-Storm added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant