Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutating a mutation that conflicts with an installed bionic causes damage #79087

Merged

Conversation

anothersimulacrum
Copy link
Member

Summary

Balance "Mutating with an installed bionic that conflicts results in damage"

Purpose of change

Old todo from #47822

Describe the solution

Allow attempting mutations when you have a bionic that conflicts with it.

When attempting to mutate a trait that conflicts with an installed bionic, roll to destroy the bionic. If the bionic is destroyed, allow the mutation and give the severe version of the botched mutation effect to the player, causing them pain, blood loss, and damage to the parts on which the bionic is installed.

If the bionic is not destroyed, block the mutation and give a less severe version of the effect, with similar consequences.

Testing

Install squeaky ankles and alloy plating, take 1 cephalopod primer and 1 mutagen catalyst, wait 20 hours.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [C++] Changes (can be) made in C++. Previously named `Code` Game: Balance Balancing of (existing) in-game features. labels Jan 11, 2025
@anothersimulacrum anothersimulacrum force-pushed the actions-have-consequences branch from dab2f07 to febc7fc Compare January 11, 2025 21:53
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jan 11, 2025
Instead, the mutation can fail, inflicting some internal damage, or
destroy the bionic, causing large internal damage.

Most of the damage is through bleeding and pain, unless it's a
particularly severe injury, in which case limb damage is applied.

The exact numbers and chance in particular, don't have a particularly
strong backing.
@anothersimulacrum anothersimulacrum force-pushed the actions-have-consequences branch from febc7fc to 8f13036 Compare January 11, 2025 21:55
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Jan 11, 2025
@terribleperson
Copy link
Contributor

I think this might need more complexity than conflicting bionics breaking. Bionics that outright replace an organ should probably continue to block mutations, as there's no longer an organ to mutate (see artificial lungs, expanded digestive system). Other than total replacement CBMs though, this makes sense.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 12, 2025
@anothersimulacrum
Copy link
Member Author

CBMs can be incompatible with traits and remove them. Only incompatibility triggers this.

@GuardianDll GuardianDll merged commit e2dd3e0 into CleverRaven:master Jan 12, 2025
25 of 27 checks passed
@anothersimulacrum anothersimulacrum deleted the actions-have-consequences branch January 13, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants