Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor generic zombie balance edits 4 #72748

Merged
merged 9 commits into from
Apr 10, 2024

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented Mar 31, 2024

Summary

None

Purpose of change

Weirdness caught during the creation of #72534 that I was advised to PR separately for the ease of reviewing

Describe the solution

  • lowered scientist speed, day vision and upgrade frequency to match baseline zombies
  • took away the dodge from scientists, marines and soldiers
  • removed scientist's improved pathing
  • swapped the scientist's melee and specials to be the same as default zombies
  • took away the security guard's reduced vision range since they don't appear to have helmet weakpoints
  • buffed security guard, soldier and marine grab strength to match tough zombies
  • edited security guard's specials to match tough zombies
  • took away armored zombie's nose
  • took away ACIDPROOF from bio-op, and reduced their vision to default values
  • removed special pathing from zombie runners so they don't avoid danger

Describe alternatives you've considered

Testing

Additional context

@Karol1223 Karol1223 changed the title Minor generic zombie balance edits 3 Minor generic zombie balance edits 4 Mar 31, 2024
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 31, 2024
@Karol1223
Copy link
Contributor Author

So I just fucked up the DPS tests, because instead of using a custom monster it used our soldiers - meaning they're untouchable unless you're willing to edit the tests. I need an adult.

@I-am-Erk
Copy link
Member

I-am-Erk commented Apr 4, 2024

It's not something I feel strongly on, but the variation in a lot of these zombies is meant to capture that basic zombies aren't actually uniform... They have some variation in abilities and stats that our monster system doesn't represent too well, so in the olden days we made various of the base zombies have slightly different capabilities. Particularly the scientists are examples of that.

@Karol1223
Copy link
Contributor Author

It's not something I feel strongly on, but the variation in a lot of these zombies is meant to capture that basic zombies aren't actually uniform... They have some variation in abilities and stats that our monster system doesn't represent too well, so in the olden days we made various of the base zombies have slightly different capabilities. Particularly the scientists are examples of that.

I agree that zombies should not all be identical, but I disagree with it being done via different zombie "job-types". Instead of highlighting individual variation, this just makes it look like they are different because they're scientists, and that's just weird.

I could be persuaded to take back the changes to speed and melee stats (not special attacks though - them not biting just makes no sense), but most other things just don't make that much sense to have different. Especially dodge. It feels like dodge used to be spread around really eagerly when all shambling corpses should equally suck at it until they start evolving not to suck at it.

@github-actions github-actions bot added Code: Tests Measurement, self-control, statistics, balancing. Monsters Monsters both friendly and unfriendly. [C++] Changes (can be) made in C++. Previously named `Code` labels Apr 4, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • zombie soldier test onlys

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 8, 2024
@Karol1223 Karol1223 closed this Apr 9, 2024
@Karol1223 Karol1223 reopened this Apr 9, 2024
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 9, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 10, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 10, 2024
@akrieger akrieger merged commit eb3b3c1 into CleverRaven:master Apr 10, 2024
21 of 27 checks passed
@Karol1223 Karol1223 deleted the woohoo-lab-edits branch April 12, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants