-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow u/npc_spawn_monster to pick randomly from a group for count > 1 #71019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuardianDll
reviewed
Jan 17, 2024
Procyonae
commented
Jan 17, 2024
1986473
to
3a7bc51
Compare
GuardianDll
reviewed
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me
Didn't know default
can be used with math
data/json/effects_on_condition/npc_eocs/hallucination_eocs.json
Outdated
Show resolved
Hide resolved
Procyonae
commented
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
<Bugfix>
This is a fix for a bug (or closes open issue)
[C++]
Changes (can be) made in C++. Previously named `Code`
<Documentation>
Design documents, internal info, guides and help.
EOC: Effects On Condition
Anything concerning Effects On Condition
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
[Markdown]
Markdown issues and PRs
Mods: Defense Mode
Anything to do with the Defense Mode mod
Mods
Issues related to mods or modding
NPC / Factions
NPCs, AI, Speech, Factions, Ownership
Scenarios
New Scenarios, balancing, bugs with scenarios
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fixes #70812
Describe the solution
Adds a new field "single_type" that defaults to false but can be defined as true to replicate the old behaviour, I couldn't find any existing EoCs that want appear to want this to occur though (have a couple of ideas how it could be used tho)
Simplifies existing EoCs that were using the workaround of multiple 1 count EoCs
Updates documentation
Describe alternatives you've considered
Testing
Tested using the below EoCs with expected results
If anyone can think of anything else I should test comment below
Additional context