Portal storm crashes the game / Segmentation fault

[Noroji]

Describe the bug

Was outside in a portal storm, talking with the nice voice on the other side.

Game crashed in the dialog as I was about to stop talking with it, restarted and reloaded the last save. Since then the game crashes after a short time of playing, usually some in game minutes. Sometimes I can move around, sometimes I can speak to the voice again for a bit, but after a short time it always ends up crashing again. Waiting inside a basement also crashes.

Attach save file

Meadville-trimmed.tar.gz

Steps to reproduce

1. Load save
2. Wait a bit or go out and take a stroll with my broadsword
3. Games crashes

Expected behavior

Portal Storms are dangerous, but the level of danger should not be coming through the game into the real world and hamper me from playing.

Screenshots

No response

Versions and configuration

• OS: Windows
  • OS Version: 10.0.19045.3930 (22H2)
• Game Version: 3ff9e99 [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Slowdown Fungal Growth [no_fungal_growth],
  Bionic Professions [package_bionic_professions],
  Magiclysm [magiclysm],
  Medieval Mod Reborn [Medieval_Mod_Reborn],
  MST Extra [MST_Extra],
  Nonperishable Overhaul [Nonperishable_Overhaul],
  Sly's Skill Antirust [slysskillantirust],
  SpeedyDex [speedydex],
  Stats Through Skills [StatsThroughSkills],
  Tamable Wildlife [Tamable_Wildlife],
  Extra Mutated Scenarios [extra_mut_scens],
  <color_light_green>Cataclysm++ [Cata++],
  Portal Storms Ignore NPCs [personal_portal_storms],
  Stats Through Kills [stats_through_kills],
  <color_cyan>Arcana and Magic Items [Arcana],
  Blaze Industries [blazeindustries],
  Make bows great again [bow_opness],
  Xedra Evolved [xedra_evolved],
  <color_cyan>Arcana/<color_light_green>Cata++ Patchmod [Arcana_Cata++_Patch],
  <color_cyan>Arcana/Magiclysm Patchmod [Arcana_Magiclysm_Patch],
  Mythical Martial Arts [MMA],
  <color_yellow>Mythical Martial Arts - Mods Extension [MMA_Mods_Extension],
  Magiclysm Revamp and Additions [magicrevamp],
  No Fungal Monsters [No_Fungi],
  Mutation Selector [mutation_selector],
  Mind Over Matter [mindovermatter],
  <color_light_blue>Lighter Weariness [light_weariness],
  Different sized rings for Mutations [Rings_For_Mag_Mut],
  Dreamforged Fire Axe for the halligan bar [Xedra_Fire_Axe],
  Aftershock [aftershock],
  Bombastic Perks [bombastic_perks],
  Translate Complex Dialogue [translate_dialogue],
  Targeted Mutagens [targetedmutagens]
  ]

Additional context

Also made a backup and removed most mods that aren't bundled with the game. Loads of errors of course, but same behaviour that it crashed after walking a bit in the storm or waiting in my basement.

crash.log

[andrei8l]

/confirmed introduced by #71019

target_monsters can be empty here

Cataclysm-DDA/src/npctalk.cpp

Line 5787 in 3ff9e99

Creature *copy = target_monsters[ rng( 0, target_monsters.size() - 1 ) ];

and probably also in the identical code below

@Procyonae

better crash.log with -D_GLIBCXX_ASSERTIONS

The program has crashed.
See the log file for a stack trace.
CRASH LOG FILE: /home/andrei/.config/cataclysm-dda/crash.log
VERSION: 0.G-6661-g3ff9e997ba
TYPE: Signal
MESSAGE: SIGABRT: Abnormal termination
STACK TRACE:

    0x555,557,3f9,d1c    …/src/debug.cpp:952    bt_full
    0x555,557,3f9,eed    …/src/debug.cpp:1,217    debug_write_backtrace(std::ostream&)
    0x555,557,3b8,3ba    …/src/crash.cpp:85    log_crash
    0x555,557,3b8,7a8    …/src/crash.cpp:138    signal_handler
    0x7ff,ff7,76f,70f    [unknown src]:0    [unknown func]
    0x7ff,ff7,7bf,83c    [unknown src]:0    [unknown func]
    0x7ff,ff7,76f,667    [unknown src]:0    [unknown func]
    0x7ff,ff7,757,4b7    [unknown src]:0    [unknown func]
    0x7ff,ff7,add,3b1    …/src/debug/gcc/gcc/libstdc++-v3/src/c++11/debug.cc:61    std::__glibcxx_assert_fail(char const*, int, char const*, char const*)
    0x555,557,828,b00    /usr/include/c++/13.2.1/bits/stl_vector.h:1,125    std::vector<Creature*, std::allocator<Creature*> >::operator[](unsigned long)
    0x555,557,fc0,ab8    …/src/npctalk.cpp:5,787    operator()
    0x555,557,fc1,061    /usr/include/c++/13.2.1/bits/invoke.h:61    __invoke_impl<void, talk_effect_fun_t::set_spawn_monster(const JsonObject&, std::string_view, bool)::<lambda(dialogue&)>&, dialogue&>
    0x555,557,fc1,061    /usr/include/c++/13.2.1/bits/invoke.h:111    __invoke_r<void, talk_effect_fun_t::set_spawn_monster(const JsonObject&, std::string_view, bool)::<lambda(dialogue&)>&, dialogue&>
    0x555,557,fc1,061    /usr/include/c++/13.2.1/bits/std_function.h:290    _M_invoke
    0x555,557,2e4,4a3    /usr/include/c++/13.2.1/bits/std_function.h:591    std::function<void (dialogue&)>::operator()(dialogue&) const
    0x555,557,f75,48b    …/src/dialogue_helpers.h:169    talk_effect_fun_t::operator()(dialogue&) const
    0x555,557,f75,48b    …/src/npctalk.cpp:6,302    talk_effect_t::apply(dialogue&) const
    0x555,557,4f5,4f1    …/src/effect_on_condition.cpp:308    effect_on_condition::activate(dialogue&) const
    0x555,557,f87,8d5    …/src/npctalk.cpp:5,401    operator()
    0x555,557,f87,963    /usr/include/c++/13.2.1/bits/invoke.h:61    __invoke_impl<void, talk_effect_fun_t::set_weighted_list_eocs(const JsonObject&, std::string_view)::<lambda(dialogue&)>&, dialogue&>
    0x555,557,f87,963    /usr/include/c++/13.2.1/bits/invoke.h:111    __invoke_r<void, talk_effect_fun_t::set_weighted_list_eocs(const JsonObject&, std::string_view)::<lambda(dialogue&)>&, dialogue&>
    0x555,557,f87,963    /usr/include/c++/13.2.1/bits/std_function.h:290    _M_invoke
    0x555,557,2e4,4a3    /usr/include/c++/13.2.1/bits/std_function.h:591    std::function<void (dialogue&)>::operator()(dialogue&) const
    0x555,557,f75,48b    …/src/dialogue_helpers.h:169    talk_effect_fun_t::operator()(dialogue&) const
    0x555,557,f75,48b    …/src/npctalk.cpp:6,302    talk_effect_t::apply(dialogue&) const
    0x555,557,4f5,4f1    …/src/effect_on_condition.cpp:308    effect_on_condition::activate(dialogue&) const
    0x555,557,4f6,0cd    …/src/effect_on_condition.cpp:229    process_eocs
    0x555,557,4f6,320    …/src/effect_on_condition.cpp:259    effect_on_conditions::process_effect_on_conditions(Character&)
    0x555,557,1b7,367    …/src/character.cpp:2,485    Character::process_turn()
    0x555,557,4a6,00c    …/src/do_turn.cpp:639    do_turn()
    0x555,556,e89,8c3    …/src/main.cpp:851    main
    0x7ff,ff7,758,ccf    [unknown src]:0    [unknown func]
    0x7ff,ff7,758,d89    [unknown src]:0    [unknown func]
    0x555,556,e85,fb4    [unknown src]:0    [unknown func]
    0xf,fff,fff,fff,fff,fff    [unknown src]:0    [unknown func]

[Procyonae]

Portal Storms are dangerous, but the level of danger should not be coming through the game into the real world and hamper me from playing.

Skill issue smh