Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amphibian Additions #3 - Treefrog Mutants - Redo of #70219 #70529

Closed
wants to merge 6 commits into from
Closed

Amphibian Additions #3 - Treefrog Mutants - Redo of #70219 #70529

wants to merge 6 commits into from

Conversation

TheSaddestGoomba
Copy link
Contributor

Summary

Content "Addition of three new, big-sized treefrog mutants. Minor tweaks to existing frog mutants."

Purpose of change

Continuation of #67029 . Reimplementation of #70219 .

Describe the solution

Describe alternatives you've considered

Testing

Additional context

Reproduction of PR #70219 on a fresh branch.
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map Mods: Tamable Wildlife labels Dec 30, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @Termineitor244

data/json/speech.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Dec 30, 2023
data/json/speech.json Outdated Show resolved Hide resolved
data/json/speech.json Outdated Show resolved Hide resolved
data/json/speech.json Outdated Show resolved Hide resolved
data/json/speech.json Outdated Show resolved Hide resolved
data/json/speech.json Outdated Show resolved Hide resolved
Redone from fresh json file
@@ -1705,19 +1705,19 @@
},
{
"type": "speech",
"speaker": [ "mon_shoggoth", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon" ],
"speaker": [ "mon_shoggoth", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon", "mon_vocal_frog" ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JSON & C++ formatters] reported by reviewdog 🐶

Suggested change
"speaker": [ "mon_shoggoth", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon", "mon_vocal_frog" ],
"speaker": [
"mon_shoggoth",
"mon_mi_go",
"mon_mi_go_slaver",
"mon_mi_go_surgeon",
"mon_mi_go_guard",
"mon_mi_go_myrmidon",
"mon_vocal_frog"
],

"sound": "a gurgling sound.",
"volume": 10
},
{
"type": "speech",
"speaker": [ "mon_shoggoth", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon" ],
"speaker": [ "mon_shoggoth", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon", "mon_vocal_frog" ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JSON & C++ formatters] reported by reviewdog 🐶

Suggested change
"speaker": [ "mon_shoggoth", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon", "mon_vocal_frog" ],
"speaker": [
"mon_shoggoth",
"mon_mi_go",
"mon_mi_go_slaver",
"mon_mi_go_surgeon",
"mon_mi_go_guard",
"mon_mi_go_myrmidon",
"mon_vocal_frog"
],

"sound": "a choking sound.",
"volume": 10
},
{
"type": "speech",
"speaker": [ "mon_shoggoth", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon" ],
"speaker": [ "mon_shoggoth", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon", "mon_vocal_frog" ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JSON & C++ formatters] reported by reviewdog 🐶

Suggested change
"speaker": [ "mon_shoggoth", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon", "mon_vocal_frog" ],
"speaker": [
"mon_shoggoth",
"mon_mi_go",
"mon_mi_go_slaver",
"mon_mi_go_surgeon",
"mon_mi_go_guard",
"mon_mi_go_myrmidon",
"mon_vocal_frog"
],

@@ -2113,7 +2113,7 @@
},
{
"type": "speech",
"speaker": [ "mon_leech_blossom", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon" ],
"speaker": [ "mon_leech_blossom", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon", "mon_vocal_frog" ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JSON & C++ formatters] reported by reviewdog 🐶

Suggested change
"speaker": [ "mon_leech_blossom", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon", "mon_vocal_frog" ],
"speaker": [
"mon_leech_blossom",
"mon_mi_go",
"mon_mi_go_slaver",
"mon_mi_go_surgeon",
"mon_mi_go_guard",
"mon_mi_go_myrmidon",
"mon_vocal_frog"
],

Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A small brown frog with a very big voice. When it calls, its whole criss-crossed torso expands and trembles like an inflatable suit. The loud squeeky sound it makes is more charming than troubling. The frequency can be exhausting.
  • On, thick over-proportioned legs this large treefrog slings its weight with notable force. It doesn't seem a danger, but its size is still cause for concern. Even scrunched up, it is as large as a Thanksgiving turkey.
  • You've seen enough to gather that this is a frog with some very specialized camouflage. Its skin appears able to reactively change texture and color to match its surroundings. Like a morphing ghillie suit it can extend filamints to mimic individual leaves and blades of grass. It is keen enough to match the swaying of brush in the wind.
  • jumbo treefrog
  • jumbo treefrogs
  • mimic treefrog
  • mimic treefrogs
  • wailing treefrog
  • wailing treefrogs

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Dec 30, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 31, 2023
@TheSaddestGoomba TheSaddestGoomba deleted the Treefrogs-v2 branch December 31, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Tamable Wildlife Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant