-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amphibian Additions #3 - Treefrog Mutants - Redo of #70219 #70529
Amphibian Additions #3 - Treefrog Mutants - Redo of #70219 #70529
Conversation
Reproduction of PR #70219 on a fresh branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-requesting reviews from non-collaborators: @Termineitor244
Undo undesired linting of speech entries
Redone from fresh json file
data/json/speech.json
Outdated
@@ -1705,19 +1705,19 @@ | |||
}, | |||
{ | |||
"type": "speech", | |||
"speaker": [ "mon_shoggoth", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon" ], | |||
"speaker": [ "mon_shoggoth", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon", "mon_vocal_frog" ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JSON & C++ formatters] reported by reviewdog 🐶
"speaker": [ "mon_shoggoth", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon", "mon_vocal_frog" ], | |
"speaker": [ | |
"mon_shoggoth", | |
"mon_mi_go", | |
"mon_mi_go_slaver", | |
"mon_mi_go_surgeon", | |
"mon_mi_go_guard", | |
"mon_mi_go_myrmidon", | |
"mon_vocal_frog" | |
], |
data/json/speech.json
Outdated
"sound": "a gurgling sound.", | ||
"volume": 10 | ||
}, | ||
{ | ||
"type": "speech", | ||
"speaker": [ "mon_shoggoth", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon" ], | ||
"speaker": [ "mon_shoggoth", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon", "mon_vocal_frog" ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JSON & C++ formatters] reported by reviewdog 🐶
"speaker": [ "mon_shoggoth", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon", "mon_vocal_frog" ], | |
"speaker": [ | |
"mon_shoggoth", | |
"mon_mi_go", | |
"mon_mi_go_slaver", | |
"mon_mi_go_surgeon", | |
"mon_mi_go_guard", | |
"mon_mi_go_myrmidon", | |
"mon_vocal_frog" | |
], |
data/json/speech.json
Outdated
"sound": "a choking sound.", | ||
"volume": 10 | ||
}, | ||
{ | ||
"type": "speech", | ||
"speaker": [ "mon_shoggoth", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon" ], | ||
"speaker": [ "mon_shoggoth", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon", "mon_vocal_frog" ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JSON & C++ formatters] reported by reviewdog 🐶
"speaker": [ "mon_shoggoth", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon", "mon_vocal_frog" ], | |
"speaker": [ | |
"mon_shoggoth", | |
"mon_mi_go", | |
"mon_mi_go_slaver", | |
"mon_mi_go_surgeon", | |
"mon_mi_go_guard", | |
"mon_mi_go_myrmidon", | |
"mon_vocal_frog" | |
], |
data/json/speech.json
Outdated
@@ -2113,7 +2113,7 @@ | |||
}, | |||
{ | |||
"type": "speech", | |||
"speaker": [ "mon_leech_blossom", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon" ], | |||
"speaker": [ "mon_leech_blossom", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon", "mon_vocal_frog" ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JSON & C++ formatters] reported by reviewdog 🐶
"speaker": [ "mon_leech_blossom", "mon_mi_go", "mon_mi_go_slaver", "mon_mi_go_surgeon", "mon_mi_go_guard", "mon_mi_go_myrmidon", "mon_vocal_frog" ], | |
"speaker": [ | |
"mon_leech_blossom", | |
"mon_mi_go", | |
"mon_mi_go_slaver", | |
"mon_mi_go_surgeon", | |
"mon_mi_go_guard", | |
"mon_mi_go_myrmidon", | |
"mon_vocal_frog" | |
], |
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
Summary
Content "Addition of three new, big-sized treefrog mutants. Minor tweaks to existing frog mutants."
Purpose of change
Continuation of #67029 . Reimplementation of #70219 .
Describe the solution
Describe alternatives you've considered
Testing
Additional context