Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treefrog mutants #70219

Closed
wants to merge 12 commits into from
Closed

Treefrog mutants #70219

wants to merge 12 commits into from

Conversation

TheSaddestGoomba
Copy link
Contributor

@TheSaddestGoomba TheSaddestGoomba commented Dec 14, 2023

Summary

Content "Add treefrog mutants"

Purpose of change

Adds three new frog mutants. Advanced mutants of the vocal treefrog and shifting treefrog.
Third implementation of: #67029

Describe the solution

Describe alternatives you've considered

Adjusting the cooldown of PARROT. It's a challenge finding the sweet spot.
Not giving PARROT to spring peepers, but they are the only chorus frog in game, the source of the vocal mutants, and named for their calls.
Having the vocal treefrogs share the "a high-pitched tittering" sound of the new star vampires added by @Standing-Storm . Just a little frightening misdirection for observant players and some extra spooky vibes to the harmless mutants. I considered a "tekeli-li" variant as well but thought it too unsubtle for the frequency. Implemented now, I can back out the last commit if needed.

Testing

TP'd around a fresh world to check spawns, time skipped to test evolution and reproduction.
Combat tests were simple for these. Stats feel right. Weak points, dissection, and butchery all check out.
Parroting works, and feels right. Frequent enough I might consider taking action in play, either chasing off or killing the frogs, if they were near my base. Not so frequent that I would feel obligated to or would cause headaches when out exploring the world.
Flags check out. This is ready for review.

Additional context

-Clean up monster descriptions
-Change some copied elements to shrink json
-Force "NULL" category on 'normal' mutant frogs
-Adjust flags for many amphibians, mostly adding/removing POISON and SWARMS
-Other small changes
-Update amphibian monster groups to include new treefrog mutants
-Lowered spawn delays to better match that of other creature types
Add the following monsters:
-Jumbo Treefrog
-Wailing Frog
-Mimic Frog
Give speech lines to the spring peeper and vocal frog mutants.
Uncapitalize names
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Dec 14, 2023
-Added upgrade groups for the new tree frogs
-Edited speech.json assignments
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A small brown frog with a very big voice. When it calls, its whole criss-crossed torso expands and trembles like an inflatable suit. The loud squeeky sound it makes is more charming than troubling. The frequency can be exhausting.
  • On, thick over-proportioned legs this large treefrog slings its weight with notable force. It doesn't seem a danger, but its size is still cause for concern. Even scrunched up, it is as large as a Thanksgiving turkey.
  • You've seen enough to gather that this is a frog with some very specialized camouflage. Its skin appears able to reactively change texture and color to match its surroundings. Like a morphing ghillie suit it can extend filamints to mimic individual leaves and blades of grass. It is keen enough to match the swaying of brush in the wind.
  • a long, soft squeek.
  • jumbo treefrog
  • jumbo treefrogs
  • mimic treefrog
  • mimic treefrogs
  • wailing treefrog
  • wailing treefrogs

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Spring peepers peep (but less than vocal frogs)
Mimic frog had the foul toad's flags; replaced with its own
Adding these speaker entries as its own commit in case it needs backing out.
@TheSaddestGoomba TheSaddestGoomba marked this pull request as ready for review December 15, 2023 18:37
Only single space in creature description, corrected to double-space
Almost forgot the mods
@github-actions github-actions bot added Mods Issues related to mods or modding Mods: Tamable Wildlife labels Dec 15, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @Termineitor244

@TheSaddestGoomba
Copy link
Contributor Author

I'm not sure what's tripping an error but I'm pretty sure it's independent of the PR changes.
Last time I needed to rebase.
Could anyone more experienced chime in?

@TheSaddestGoomba TheSaddestGoomba mentioned this pull request Dec 18, 2023
82 tasks
@TheSaddestGoomba TheSaddestGoomba marked this pull request as draft December 30, 2023 20:08
@TheSaddestGoomba
Copy link
Contributor Author

Converting to draft to attempt a fresh PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Tamable Wildlife Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant