[CR] Camp calorie test

[RenechCDDA]

Summary

None

Purpose of change

Camps are woefully underserved by our test suite.

Describe the solution

Make tests for things that have caused issues in the past and could come up again (e.g. #50805)

Describe alternatives you've considered

Let someone else write the tests? Hasn't worked so far!

Testing

This runs and works locally, both as an individual test, running just those two tests(this one and EOC_transform_radius) together, and running the whole suite.

Additional context

Ran into some problems with test ordering, see comments.

[RenechCDDA]

I cannot get the character to craft, and I do not know why. I haven't pushed these commits but I've tried:
Giving the items directly to their inventory
Giving them a debug backpack to make sure they have space
Checking they did in fact get the component items (they did)

Any help would be appreciated.

[PatrikLundell]

I don't know anything about the testing stuff, so it might not be any help...

Edit: Replaced what was below with something that might be less incorrect.

My interpretation of the code is that it starts crafting and verified the in process craft is wielded. It then just advances the time, but doesn't make any call that would actually cause the crafting to finalize.

[RenechCDDA]

I don't know anything about the testing stuff, so it might not be any help...

Edit: Replaced what was below with something that might be less incorrect.

My interpretation of the code is that it starts crafting and verified the in process craft is wielded. It then just advances the time, but doesn't make any call that would actually cause the crafting to finalize.

It actually did try to start the craft, it just repeatedly refused to acknowledge that the character had components on hand. It was very bizarre.

Regardless, I have abandoned the "actually craft it" approach in favor of just inserting the components into the item via code.

[RenechCDDA]

Aaaand it's not playing well on CI. Worked fine on my machine!

This is going to be an annoying one, isn't it?

[RenechCDDA]

I assumed that the failure to place items into zone_loc was possibly due to it being unloaded (player character not necessarily in the same map, although weird that it works reliably on my machine). Setting the player's pos was supposed to resolve that, but clearly it hasn't.... I wonder if this a test ordering issue?

edit: ok yes, it does error out on my machine when I run the full test suite. So, most likely an ordering issue. Drat

[ehughsbaird]

With #68154 figured out, it's a conflict with the EOC_transform_radius test. tests/cata_test "EOC_transform_radius,camp_calorie_counting" will consistently reproduce it.

[RenechCDDA]

Looks like it specifically places the player out of bounds during that test, yeah. I am open to suggestions on how to resolve this that isn't "Just run the faction camp test first".

[ehughsbaird]

If that's what's happening, that test should probably place the player back in bounds (do this), or this test should place the player inbounds first (leaving that test to potentially break other tests).

[RenechCDDA]

That does sound like a fine solution when I think about it hah. I'll poke it sometime today.

[RenechCDDA]

Ok so this runs and works locally, both as an individual test, running just those two tests together, and running the whole suite (sans the expected translation failures).

But I would appreciate a second look so it doesn't look like I'm doing something really nuts.

[RenechCDDA]

OK, so now it consistently passes on windows and consistently fails on... whatever the GCC 9, Curses, LTO step runs.