Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

15x (!) increase in test run time #68154

Closed
ehughsbaird opened this issue Sep 15, 2023 · 1 comment · Fixed by #68155
Closed

15x (!) increase in test run time #68154

ehughsbaird opened this issue Sep 15, 2023 · 1 comment · Fixed by #68155
Labels
Code: Performance Performance boosting code (CPU, memory, etc.) Code: Tests Measurement, self-control, statistics, balancing. (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@ehughsbaird
Copy link
Contributor

Describe the bug

After #67997, running the full suite of tests takes 3 hours. If that is reverted, it takes 12 minutes.

Attach save file

N/A

Steps to reproduce

  1. Build tests
  2. Run tests
  3. Wait 3 hours for tests to complete
  4. Revert f12487c
  5. Build tests
  6. Run tests
  7. Wait ~12 minutes for tests to complete

Expected behavior

Tests take much less than 3 hours to run.

Screenshots

perf profile:
image

Versions and configuration

Commit d6d150c

Additional context

No response
@ehughsbaird ehughsbaird added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Sep 15, 2023
@ehughsbaird ehughsbaird mentioned this issue Sep 15, 2023
Merged
@RenechCDDA
Copy link
Member

I noticed that my last local test run took an astounding 2 hours, 15 minutes. Previously test runs were around 30 minutes (45 if I was actively using the computer for other things). This is definitely a problem.

@RenechCDDA RenechCDDA added (S2 - Confirmed) Bug that's been confirmed to exist Code: Tests Measurement, self-control, statistics, balancing. Code: Performance Performance boosting code (CPU, memory, etc.) and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Sep 15, 2023
@ehughsbaird ehughsbaird mentioned this issue Sep 15, 2023
Merged
@ZhilkinSerg ZhilkinSerg mentioned this issue Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code: Performance Performance boosting code (CPU, memory, etc.) Code: Tests Measurement, self-control, statistics, balancing. (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not update visibility cache every two minutes CleverRaven/Cataclysm-DDA
2 participants
@ehughsbaird @RenechCDDA