Fix crash in item_location serialization #62960
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fixes #62078
Fixes #62954
Describe the solution
Check container location before accessing it.
Move activity backlog deserialization to after character id deserialization because item locations on character depend on the id being loaded. Kind of a followup to #54323.
Describe alternatives you've considered
Testing
Saving would trigger the crash without this fix, now it doesn't.
The stale activity with stale item_locations will still be in the backlog and cause errors when loading, but they can be ignored.
Additional context