Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysterious crash to desktop #62078

Closed
KHeket opened this issue Nov 4, 2022 · 20 comments · Fixed by #62960
Closed

Mysterious crash to desktop #62078

KHeket opened this issue Nov 4, 2022 · 20 comments · Fixed by #62960
Labels
<Crash / Freeze> Fatal bug that results in hangs or crashes. Items / Item Actions / Item Qualities Items and how they work and interact (S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@KHeket
Copy link
Contributor

KHeket commented Nov 4, 2022

Describe the bug

Random crash to descop with segmentation fault text. Screenshot below. I am also playing on russian version, but I dont think that it is the reason

Steps to reproduce

I dunno what is causing this crash, becouse always it happens accidentally. In forests, while gathering berries, in open field
just simple walking to distination point. I dont know how to find out the reason. But in happens 5 times in this game, and lot of time in privios games

Expected behavior

I expected no crashes and no starting again from last save point

Screenshots

crash screenshot

image

And I dontknow why after each crush my character duplicates

screenshot

image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19044.2130 (21H2)
  • Game Version: 300ec6d [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions]
    ]

Additional context

crash.log
debug.log

@KHeket KHeket added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Nov 4, 2022
@NetSysFire
Copy link
Member

Looking at crash.log it appears to be related to autosave and more specifically, it processing items in containers. Can you save manually or does it crash, too?

@NetSysFire NetSysFire added the <Crash / Freeze> Fatal bug that results in hangs or crashes. label Nov 4, 2022
@KHeket
Copy link
Contributor Author

KHeket commented Nov 4, 2022

Looking at crash.log it appears to be related to autosave and more specifically, it processing items in containers. Can you save manually or does it crash, too?

I can save. I am playing for a long time, one time I have crash while manual saving. And there is crash messages about items in conteiners, when I am loading game after segmentation fault crash. I will try to screen them, when it happen again, and send here logs

@NetSysFire
Copy link
Member

And there is crash messages about items in conteiners

Sounds like some stuff got corrupted. So far it really does sound like an issue related to saving. Does this happen in a clean new world, too?

@KHeket
Copy link
Contributor Author

KHeket commented Nov 5, 2022

And there is crash messages about items in conteiners

Sounds like some stuff got corrupted. So far it really does sound like an issue related to saving. Does this happen in a clean new world, too?

What do you mean by clean world?

@PatrikLundell
Copy link
Contributor

Clean world = New world with a new character (so there's no existing save that may contain corruptions).

@KHeket
Copy link
Contributor Author

KHeket commented Nov 5, 2022

Clean world = New world with a new character (so there's no existing save that may contain corruptions).

Its always happening after some time, or I dont remember this on clean world

@KHeket
Copy link
Contributor Author

KHeket commented Nov 6, 2022

It happend again after a long time, when I came to mass graveyard. There was no crash messages after reloading. And I also played for a long time without crashes

Crash screenshots

image

Place where the crash was. When I came here again - no problem. Manual saving is ok, no crash

image

crash.log
debug.log

@NetSysFire NetSysFire changed the title Unreasonable crash to descop Unreasonable crash to desktop Nov 6, 2022
@mqrause
Copy link
Contributor

mqrause commented Nov 7, 2022

Looks like it tries to serialize an invalid item_location from the pickup activity. It crashes trying to access the pockets, indicating the item doesn't exist. Not sure how that happens, though. I would have guessed it's related to #52426, but that doesn't sound too likely when it happens this regularly.

@NetSysFire NetSysFire changed the title Unreasonable crash to desktop Mysterious crash to desktop Nov 7, 2022
@NetSysFire NetSysFire added the Items / Item Actions / Item Qualities Items and how they work and interact label Nov 7, 2022
@NetSysFire
Copy link
Member

As the one who opened that mentioned issue, I know there can be other triggers such as items burning in a fire (mentioned in there, too) and possibly more.

The only thing I can think of right now that may possibly help in getting to the bottom of it is to save manually more often and to upload the save immediately when you get a crash so it may possibly reproducible for someone else, too. I am unsure how much gets actually saved when it crashes like this, so this may be a long shot.

@KHeket
Copy link
Contributor Author

KHeket commented Nov 10, 2022

Happend again while I gathering berries in new game. And also there was no crash, until I didnt wear all this (at screenshot below) stuff and went for gathering. I am now sure, but I thinh problem is in pair of drop leg pouches, becouse there was no crashes, but when I equipped them - here it is after some time. Or something else. I dont know. May be just lucky for crash
What should I do? Do you need me to still sending crash logs there with describes of situations?

Crash screenshots

image

image

crash.log
debug.log

@EIIKaO
Copy link
Contributor

EIIKaO commented Nov 13, 2022

From the latest attached crash.log, it appears that there is a problem with the process when picking up items.
This seems a bit different from the problem expected in the earlier crash.logs.

I have tried to create a similar situation ( equipped with a large number of backpacks includes pair of drop leg pouches, wielding body bag in my hand, and carrying items close to the weight limit ) to collect berries and other resources, but no crashes occurred.

This has already been discussed, but if you could attach a save file where the crash can be reproduced, we can do a more detailed analysis.

@KHeket
Copy link
Contributor Author

KHeket commented Nov 13, 2022

Problem is in inability of forced reproducing. Becouse I have crash in one sutiation, and then came to this place again and make simular action (not identical, because I cant remember all steps) - and no crash. And I dont know how to find out the problem

@KHeket
Copy link
Contributor Author

KHeket commented Nov 16, 2022

crash.log
debug.log

Another one crash, now with crash text after loading. I will send here text on english, and screenshots on russian. Happend becouse of me trying to manualy saving. I was recording game, and show you last 15 seconds. I used . Manualy saving triggered the crash. I will try to reproduce it. So its didnt happend becouse of picking up something

Crash message

DEBUG : parent location does not point to valid item

FUNCTION : void item_location::deserialize(const JsonObject&)
FILE : src/item_location.cpp
LINE : 802
VERSION : 90c0612

image

Video
_Trim.mp4

@KHeket
Copy link
Contributor Author

KHeket commented Nov 16, 2022

Tryed to reproduce - no crash. Killed a lot of zombies standing at the place, where I saved on video, spawning quick save - no crash happend. But there was new crash message after first save. No new info in crash log, but lot of messages in debug log. And no crash to windows, just massage in game
debug.log

@KHeket
Copy link
Contributor Author

KHeket commented Nov 30, 2022

I have save file with reproducable situation, but size of it is 1.7 GB, how can I load such big file to github?

@mqrause
Copy link
Contributor

mqrause commented Nov 30, 2022

You'd have to upload it to a third party site, but even then 1.7 GB is pretty insane. Maybe someone has some advice on how to shrink it down to a more manageable size.

@PatrikLundell
Copy link
Contributor

Much of the time the .mm1 directory within the save can be removed from a copy of the save before that copy is zipped up. As far as I understand this directory contains the "memory" of what you've seen, which usually isn't important for bug reproduction and analysis. If that's done I'd verify the modified copy still is capable of reproducing the issue before posting it, though.

It's often possible to delete the map details of everything that's not in the immediate vicinity of the player, but that's more fiddly and first requiring figuring out "in which folder" the player currently is.

Regardless, any save manipulation should be done on a copy of the save so the original isn't harmed.

@KHeket
Copy link
Contributor Author

KHeket commented Dec 2, 2022

Much of the time the .mm1 directory within the save can be removed from a copy of the save before that copy is zipped up. As far as I understand this directory contains the "memory" of what you've seen, which usually isn't important for bug reproduction and analysis. If that's done I'd verify the modified copy still is capable of reproducing the issue before posting it, though.

It's often possible to delete the map details of everything that's not in the immediate vicinity of the player, but that's more fiddly and first requiring figuring out "in which folder" the player currently is.

Regardless, any save manipulation should be done on a copy of the save so the original isn't harmed.

I have deleted sounds and mm1 directory and dicrease game size to ~ 1 GB and zipped it have size of 140 MB. But for now I need to find way to overcome the github limit in 25 mb. Do somebody know a good third party site or something else?

@Zireael07
Copy link
Contributor

Dropbox is one of the free sites that can comfortably store 140 MB (iirc it has 2 GB for free). MEGA is another

@KHeket
Copy link
Contributor Author

KHeket commented Dec 2, 2022

Thx for dropbox. Here is the link to the file
https://www.dropbox.com/s/slor0fv7hvmu8ug/cdda%20%E2%80%94%20%D0%BA%D0%BE%D0%BF%D0%B8%D1%8F.7z?dl=0
To reproduce the crash, make sure that autopickup is on, its set to F2, then go to the pile of items and see the crash. I will also attach video

2022-12-02.23-59-31_Trim.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Crash / Freeze> Fatal bug that results in hangs or crashes. Items / Item Actions / Item Qualities Items and how they work and interact (S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants