Display name of loaded ammo instead of ammo type

[eltank]

Summary

Interface "Display name of loaded ammo instead of ammo type"

Purpose of change

Magazines and guns loaded with different ammo variants are indistinguishable from each other in the inventory screen. The suffix displayed after the gun/magazine name shows the amount of ammo loaded but instead of ammo name it shows ammo type. This PR changes the suffix to show actual ammo loaded when there is ammo.

Describe the solution

Change item::display_name. When there is ammo loaded, use the name of the ammo as ammotext. Otherwise compute it as before.

Describe alternatives you've considered

Testing

Spawn a bunch off different weapons, magazines and ammo variants. Load magazines with different ammo variants.

Before:

After:

Additional context

The display of ammo type was introduced in #36474. The author did intend to show ammo loaded, but it didn't work, likely due to some problems with the ammo infrastructure, which seems to be working better now. Or maybe it did work at the time, but some later refactoring broke it?

I am trying to make it show the current ammo if any is loaded

[esotericist]

works as described.