Display name of loaded ammo instead of ammo type (#51439) #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bug: guns with different ammo stack, and when stacked it's implied that both guns are loaded with same ammo ExampleWielded Same guns, stashed in inventory |
Crap, I'll look into what I should change for this and get it fixed in a bit. Update: It appears to be specific to some guns. M4A1, Barrett, etc displays properly but the shotgun doesn't. On a hunch I've tested other guns without magazines. It consistently stacks regardless of contents if it doesn't use magazines |
ammo_current returns itype_id::NULL_ID() if it doesn't have ammo and isn't ammo itself, so no worries with nullptrs.
olanti-p
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Display name of loaded ammo instead of ammo type (#51439)"
Purpose of change
It's nice to know which one of my guns is loaded with FMJ or JHP so I can figure out which gun I should use on the armoured enemies
Describe the solution
Ports #51439.
Describe alternatives you've considered
Much less useful, I'd prefer it tell me the ammo group usable for the gun rather than the specific default ammo it assumes.
Testing
Spawned multiple Barrett rifles and M1911, loaded them with different ammunition and checked that they displayed correctly. Unloaded all of them and checked that they still displayed ammo group as expected.
Additional context
Came across it while looking over the Proportional and Relative support PR