Disable nonfunctional vitamin deficiencies #49083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-nh
added
<Bugfix>
I would not describe them quite that way - more like variable in significance, although almost always less significant than the current warning messages would make it seem. But #45564 is in Feature/String freeze for 0.F anyway and definitely should be; this hotfix is a good idea for 0.F IMO, especially given all the changes that need to be made. |
anothersimulacrum
added a commit
to anothersimulacrum/Cataclysm-DDA
that referenced
this pull request
Jun 12, 2021
After CleverRaven#49083, effects will no longer be applied for most vitamin deficiencies... or lost when no longer valid. Since they don't do anything, let's remove them on load and not leave saves with an effect that does nothing sticking around.
esotericist
pushed a commit
that referenced
this pull request
Jun 12, 2021
After #49083, effects will no longer be applied for most vitamin deficiencies... or lost when no longer valid. Since they don't do anything, let's remove them on load and not leave saves with an effect that does nothing sticking around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Vitamin deficiencies show scary messages and show up in the @ menu, but they don't actually cause any gameplay change. This has been a pretty consistent complaint/concern engine that should not make it into 0.F.
Describe the solution
Removed the deficiency field of the nonfunctional vitamins, left both the vitamins themselves and the effects untouched.
Describe alternatives you've considered
Keep telling people about once a week on Discord that no, their bones did not in fact become brittle. Change the decay rate to an arbitrarily high number, but this feels cleaner.
Testing
Loads, debug-setting the vitamins to their minimum without getting messages about my eyes falling out/hair catching on fire.
Additional context
I didn't want to step on the toes of #45564 (see there for an exhaustive discussion on the relevance of vitamins in an irl survival scenario - TL,DR: pretty insignificant), but this has been a bugbear of mine for a while now.