Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bionic enhanced hearing takes effect only when activated #48870

Merged
merged 2 commits into from
May 14, 2021

Conversation

RoyBerube
Copy link
Contributor

Summary

Bugfixes "Bionic enhanced hearing takes effect only when activated"

Purpose of change

Fixes #48865

Describe the solution

The active effects were placed in the "flags" section instead of the "active_flags" section so they were always on. Moved them to the correct section.

Describe alternatives you've considered

Testing

Installed enhanced hearing bionic in a character with bionic power already installed. Spawned a m107a1 50 caliber rifle and ammo.

Rifle test.
Enhanced hearing toggled off: Ears ring on every shot fired.
Enhanced hearing toggled on: No ears ringing when shots fired.

In a room with many zombies nearby outside the building.
Enhanced hearing toggled off: Cannot hear any movement.
Enhanced hearing toggled on: Constantly hear movement outside.

Additional context

@Maleclypse Maleclypse added <Bugfix> This is a fix for a bug (or closes open issue) Bionics CBM (Compact Bionic Modules) labels May 14, 2021
@Salty-Panda
Copy link
Contributor

Salty-Panda commented May 14, 2021

Please keep IMMUNE_HEARING_DAMAGE inside flags.
Description says "high-intensity sounds will be automatically dampened", same way as eye equivalent of this bionic that protects from bright flashes and welding doesn't require activation to function.
Also it was probably the main reason for installing this bionic, while enhanced hearing is just an annoyance.

If you really think they should require activation maybe make it a separate fake bionic (this bionic already has one that removes all sounds) that requires a bit of power to function. Just don't make players see the spam of imagined (or maybe subways/tunnels) noises that always appear when you enable this bionic.

data/json/bionics.json Outdated Show resolved Hide resolved
@ZhilkinSerg ZhilkinSerg merged commit 6e372ee into CleverRaven:master May 14, 2021
@RoyBerube RoyBerube deleted the bio_ears branch May 15, 2021 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bionics CBM (Compact Bionic Modules) <Bugfix> This is a fix for a bug (or closes open issue)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhanced Hearing Bionic does not toggle off
4 participants