Bionic enhanced hearing takes effect only when activated #48870
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Bionic enhanced hearing takes effect only when activated"
Purpose of change
Fixes #48865
Describe the solution
The active effects were placed in the "flags" section instead of the "active_flags" section so they were always on. Moved them to the correct section.
Describe alternatives you've considered
Testing
Installed enhanced hearing bionic in a character with bionic power already installed. Spawned a m107a1 50 caliber rifle and ammo.
Rifle test.
Enhanced hearing toggled off: Ears ring on every shot fired.
Enhanced hearing toggled on: No ears ringing when shots fired.
In a room with many zombies nearby outside the building.
Enhanced hearing toggled off: Cannot hear any movement.
Enhanced hearing toggled on: Constantly hear movement outside.
Additional context