Apply migrations to more jmapgens #45413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmapgen_spawn_item and jmapgen_liquid_item did not migrate items passed to them. This showed up when spawning in a rural gas station with generic guns, a shotgun and shot for it would be spawned, but not migrated to the generic guns versions. Migrate those now.
anothersimulacrum
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Make sure items spawned during mapgen are migrated"
Purpose of change
Fixes #40408
Describe the solution
jmapgen_spawn_item and jmapgen_liquid_item did not migrate items passed to them. This showed up when spawning in a rural gas station with generic guns, a shotgun and shot for it would be spawned, but not migrated to the generic guns versions.
Migrate those now.
Testing
Create a world with the generic guns mod, start in the last delivery scenario. Look around for either the shotgun or shotgun shells, and see they are properly migrated.