Misc bugfixes from DDA 5 #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: olanti-p <olanti-p@yandex.ru>
It's not intended that a survivor can install more than 2 engines in a vehicle, yet it is still useful to be able to install more than 2 engines for vehicle creation. Additionally, it was often asked how to get to mechanics 12, an effectively impossible task, but still show for the install requirements for 2+ engines. As such, require debug hammerspace to install more than 2 engines or display the skills need to install more engines. The skills don't mean anything after 2 engines, but it's easier to leave them there, and there is no harm in doing so.
* allow chargeless firestarters to interact with furniture * have firestarter use function decide if fire can be started * keep checking charges for charged firestarters
jmapgen_spawn_item and jmapgen_liquid_item did not migrate items passed to them. This showed up when spawning in a rural gas station with generic guns, a shotgun and shot for it would be spawned, but not migrated to the generic guns versions. Migrate those now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
Preemptive bugfixing
Describe the solution
Cherry-picked from DDA:
CleverRaven#45399 (squashed with #45904; there were some more problems, so I've squashed my own fixes on top of it)
CleverRaven#45773
CleverRaven#45750
CleverRaven#45835
CleverRaven#45914
CleverRaven#46021 (Latest version of BN freezes when trying to move all items from
All area withOpen default AIM layoutoption enabled. This change fixes that, but I suspect there's another bug hiding in the code.)CleverRaven#46010
CleverRaven#46104
CleverRaven#46137
CleverRaven#45413
Describe alternatives you've considered
Let the bugs strike first?
Testing
Didn't test the food stealing fix (it looks fine), but the rest worked.
The AIM resets panels when moving items from
All area one-by-one withOpen default AIM layoutoption enabled, but that's not critical.