Fix dirty fuel #44045 #44689
Merged
Fix dirty fuel #44045 #44689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does That mean I can drop water on the gas pump and have it behave like it contains water? Can I fill the gas pump with milk? |
|
No, dropping is blocked both via D and AIM, not sure if there's other ways to drop |
|
Throwing? There's no weird prompt when examining the pump? |
|
No weird prompt - just regular gas pump messages/dialog Throwing produces weird results... Tried throwing bottles of whiskey at it - |
|
Seems it's already open #43252 but regardless it doesn't seem to insert liquid into the pump |
esotericist
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Fix #44045 (most likely)
Describe the solution
Buying fuel from the terminal swaps the gas pump for null terrain, then puts
fuel on tile, then swaps terrain back to gas pump. When fuel is put on null terrain
there's no LIQUIDCONT flag on the tile so it receives DIRTY flag.
Then a few vehicle functions disagree on handling flag differences which is why
there's the debug popup in the linked issue - but that needs another PR to fix.
For now this patch removes terrain swapping and puts LIQUIDCONT on non-broken
gas pumps which prevents DIRTY flag.
Describe alternatives you've considered
Testing
Spawn gas station special with terminals to buy more fuel.
Spill all fuel out of the pumps
Buy more fuel - the fuel should have no dirty flag, should refuel and stack in tanks with other fuel of same type
Additional context