Transfering gasoline from some sources to vehicle tanks isn't working

[Svankensen]

Describe the bug

When attempting to siphon gas, or refilling a container from a vehicle from a gas pump, you get the following error:

DEBUG : tried to put an item (gasoline, amount 1) in a container (metal_tank) that cannot contain it

FUNCTION : int item::fill_with(const item&, int)
FILE : src/item.cpp
LINE : 8874

Steps To Reproduce

Try syphoning the gas in the ambulance to adjacent vehicle (attached save)

Aditional context

I noticed in another car that if I left the engine running until it ran out, the offending tanks were left with 0,0 gas instead of becoming an empty tank. It may be related.
syphoning.zip

Versions and configuration

• OS: Windows
  • OS Version: MINGW/CYGWIN/MSYS2 on unknown Windows version
• Game Version: 0.E-8638-g8e4e267 [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Bionic Professions [package_bionic_professions],
  Blaze Industries [blazeindustries],
  Aftershock [aftershock],
  Magiclysm [magiclysm]
  ]

[PaulBlay]

In the latest build some liquids in your save file had the tag
"item_tags":["DIRTY"],

(Related #46480 ? Maybe not)

I removed the DIRTY tag from the save (file 83.-18.0.map ) and reloaded - it now can be siphoned in either direction no problem.

I'm not sure why some of the tanks had dirty gasoline and some didn't. I vaguely recollect seeing something similar, but I can't remember the circumstances.

[BrettDong]

Seems like a duplicate of #45191.

[Svankensen]

Seems like a duplicate of #45191.

Interesting. This save is new tho, must have a couple days, and I'm never more than a week behind in the experimental.

[BrettDong]

This is probably because an old bug that gasoline from gas stations erroneously carry DIRTY flag, and checks introduced in #44539 refuses to mix liquids carrying different flags. The DIRTY gasoline bug has been fixed in #44689, but unfortunately old saves created before that all carry the defect. I created a new world, spawned two vehicles and tried to siphon gasoline between them and it works fine.

[Svankensen]

This is probably because an old bug that gasoline from gas stations erroneously carry DIRTY flag, and checks introduced in #44539 refuses to mix liquids carrying different flags. The DIRTY gasoline bug has been fixed in #44689, but unfortunately old saves created before that all carry the defect. I created a new world, spawned two vehicles and tried to siphon gasoline between them and it works fine.

Yeah, but I created this world yesterday, and wasn't more than a week behind in the experimental.

I believe most of the gas came from a pump in the lumbermill (not the lumberyard in the city).

[BrettDong]

Where did these two vehicles (and their gasoline) come from? I found that gasoline from one vehicle carries DIRTY flag and gasoline from the other does not, and that is the reason why they refuse to mix together.

[Svankensen]

Where did these two vehicles (and their gasoline) come from? I found that gasoline from one vehicle carries DIRTY flag and gasoline from the other does not, and that is the reason why they refuse to mix together.

Damn, you asked before my edit got through. I believe most of the gas came from a pump in the lumbermill (not the lumberyard in the city).

[Svankensen]

The rest came from a flatbed I found in the northern research facility and that is now in the road outside the prison.

[Svankensen]

There should be a steel jerrycan full of gas that I got from the pump there somewhere in the RV (already moving cars, can't point you exactly where), that one shouldn't have any confounding factors.

[BrettDong]

Gasoline from lumber mills is dirty. I made a bug fix but it is only effective for new lumber mills spawned in new experimental versions after the fix is merged. For old saves you will have to manually edit the save file to drop DIRTY flag.

[Svankensen]

Gasoline from lumber mills is dirty. I made a bug fix but it is only effective for new lumber mills spawned in new experimental versions after the fix is merged. For old saves you will have to manually edit the save file to drop DIRTY flag.

Thanks a bunch! People like you are who makes CDDA so dynamic. 11 hours for a fix. Thanks for your time!