[WIP] Bugfix unload items #40000 #40004
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifreund
added
<Bugfix>
Pupsi-Mupsi
changed the title
|
yes, that's the message i fixed by introducing this behavior in #37816 for reference |
I just got this error in my own game, so I think it is unrelated to your modifications. |
Same. See issue #39402 |
|
Unfortunately, this only partially resolves the problem and I do not intend to aggravate the existing problem with nested containers. So ... sorry, but I prefer to close this PR. |
This was referenced May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
Unloading things does not pick them up anymore.
This fixes #40000.
Testing
Unloaded an mp3 player and a bunch of other things around the character and in characters inventory.
Okay. Did some more testing and came across this.
I'll take a closer look tomorrow after work.
Any [CR] is highly appreciated!