change item_location return from an int to item_location #37816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
[C++]
This was referenced Feb 9, 2020
This was referenced Feb 16, 2020
KorGgenT
force-pushed
the
item_location-obtain
branch
from
27077ad to
d05654b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "change item_location return from an int to item_location"Purpose of change
Item indices are very fragile. They not only invalidate when the inventory changes shape, but only return the item at the top of the stack (so grabbing an item from inside another item is impossible)
Therefore, this PR is imperative for the nested container stuff i'm working on.
Describe alternatives you've considered
none
Testing
Compiled.
Tested wearing clothing as it has several sites of item_location::obtain