Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix target acquiring for the player #39065

Closed
wants to merge 1 commit into from

Conversation

AMurkin
Copy link
Contributor

@AMurkin AMurkin commented Mar 27, 2020

Summary

SUMMARY: Bugfixes "Fix target acquiring for the player"

Purpose of change

Fixes #38285

Describe the solution

It basically reverts #37983 - Fix auto attack to handle lighting and glass better.
Not quite succeeded.

Describe alternatives you've considered

Tweaking get_targetable_creatures to account for all factors.

Testing

Works like before #37983.

@Zireael07
Copy link
Contributor

Doesn't this reintroduce problems that #37983 was supposed to fix?

@AMurkin
Copy link
Contributor Author

AMurkin commented Mar 27, 2020

I think the real issue was fixed by #38730. But I will try to check it.

@Ramza13
Copy link
Contributor

Ramza13 commented Mar 27, 2020

So while this does fix an issue it reintroduces the problem of ranged melee attacks attempting to go through glass. We probably need some separate logic for ranged versus melee versus guns or something to handle that case.

@AMurkin AMurkin changed the title Fix target acquiring for the player [WIP] Fix target acquiring for the player Mar 27, 2020
@AMurkin AMurkin closed this Apr 9, 2020
@AMurkin AMurkin deleted the fix-targeting branch April 26, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-target does not auto-target through display racks
3 participants