Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-target does not auto-target through display racks #38285

Closed
CoroNaut opened this issue Feb 24, 2020 · 8 comments · Fixed by #40662
Closed

Auto-target does not auto-target through display racks #38285

CoroNaut opened this issue Feb 24, 2020 · 8 comments · Fixed by #40662
Labels
Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics stale Closed for lack of activity, but still valid.

Comments

@CoroNaut
Copy link

CoroNaut commented Feb 24, 2020

Describe the bug

As title, also noticed that it doesn't auto-target through unbroken windows

Steps To Reproduce

  1. Display rack between you and enemy
  2. Display rack blocks auto-target, but you can still aim at enemy and shoot at enemy like normal

Expected behavior

Auto target through display rack

Versions and configuration

  • OS: Windows
    • OS Version: MINGW/CYGWIN/MSYS2 on unknown Windows version
  • Game Version: 0.D-12476-gfef327b [64-bit]
  • Graphics Version: Tiles
  • Mods loaded: [
    Dark Days Ahead [dda],
    No Fungal Monsters [No_Fungi],
    Disable Religious Texts [no_religious_Texts]
    ]
@Night-Pryanik
Copy link
Contributor

Ranged auto-target or melee ranged auto-target?

@CoroNaut
Copy link
Author

This is ranged, Melee is a different story for 2-tile reach, but I think it would still be nice to have melee auto-target through display rack and windows, etc

@Night-Pryanik Night-Pryanik added Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics labels Feb 26, 2020
@Amariithynar
Copy link

I'm pretty sure I saw a recentish (last month or so) PR that went through that made it so that you can't auto-target through terrain marked impassable, so that more serious threats are targeted first in a swarm scenario. You should be able to still manually aim and fire, though.

@Ramza13
Copy link
Contributor

Ramza13 commented Mar 3, 2020

I'm pretty sure I saw a recentish (last month or so) PR that went through that made it so that you can't auto-target through terrain marked impassable, so that more serious threats are targeted first in a swarm scenario. You should be able to still manually aim and fire, though.

Yes that is correct, I added that check to prevent targeting through walls or glass. I'll take a look at this but finding the right logic for targeting though isn't easy, as in I'm not sure what flags or features differentiate a shelf you can stab through from a wall from a glass wall and it might not be doable at present without adding an additional flag.

@AMurkin
Copy link
Contributor

AMurkin commented Mar 3, 2020

Now laser weapons can't auto-target when the enemy is behind a glass wall too.

@RDru
Copy link
Contributor

RDru commented Mar 27, 2020

one other thing: auto-target still sometimes targets stuff on other z-levels, through the roof or floor.

@Ramza13
Copy link
Contributor

Ramza13 commented Mar 27, 2020

one other thing: auto-target still sometimes targets stuff on other z-levels, through the roof or floor.

Do you have any special mutations or bionics related to sight? Really thought those were taken care of.

@stale
Copy link

stale bot commented Apr 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics stale Closed for lack of activity, but still valid.
Projects
None yet
6 participants