Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a few names to en.json #37769

Merged
merged 3 commits into from
Feb 6, 2020
Merged

Added a few names to en.json #37769

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c07310f
Added a nickname
Thomasasia Feb 6, 2020
3a70e94
Added some names to en.json
Thomasasia Feb 6, 2020
c8f741b
removed fake location
Thomasasia Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions data/names/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,7 @@
{"usage": "nick", "name": "Electric"},
{"usage": "nick", "name": "Element"},
{"usage": "nick", "name": "Elite"},
{"usage": "nick", "name": "Elric"},
{"usage": "nick", "name": "Emerald"},
{"usage": "nick", "name": "Encore"},
{"usage": "nick", "name": "End Times"},
Expand Down Expand Up @@ -2235,6 +2236,7 @@
{"usage": "city", "name": "Groveland"},
{"usage": "city", "name": "Guildhall"},
{"usage": "city", "name": "Guilford"},
{"usage": "city", "name": "Gwinnett"},
{"usage": "city", "name": "Haddam"},
{"usage": "city", "name": "Hadley"},
{"usage": "city", "name": "Halifax"},
Expand Down Expand Up @@ -2515,6 +2517,7 @@
{"usage": "city", "name": "New Sharon"},
{"usage": "city", "name": "New Shoreham"},
{"usage": "city", "name": "New Sweden"},
{"usage": "city", "name": "New Vegas"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are generally based on real city names - is there a New Vegas somewhere?

Copy link
Contributor Author

@Thomasasia Thomasasia Feb 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are generally based on real city names - is there a New Vegas somewhere?

There most likely is not. It's a reference to a classic post apocalyptic video game of the same name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the place names to real ones, it's best we don't go down the road of allowing references in this particular context.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the place names to real ones, it's best we don't go down the road of allowing references in this particular context.

I gotcha, I'll get rid of that one.

All of the other places are real, so they should be good then.

{"usage": "city", "name": "New Vineyard"},
{"usage": "city", "name": "Newark"},
{"usage": "city", "name": "Newburgh"},
Expand Down Expand Up @@ -2792,6 +2795,7 @@
{"usage": "city", "name": "Sudbury"},
{"usage": "city", "name": "Suffield"},
{"usage": "city", "name": "Sugar Hill"},
{"usage": "city", "name": "Sugarloaf"},
{"usage": "city", "name": "Sullivan"},
{"usage": "city", "name": "Sumner"},
{"usage": "city", "name": "Sunapee"},
Expand Down