-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a few names to en.json #37769
Added a few names to en.json #37769
Conversation
These seem to be normal names that can be added just fine. |
data/names/en.json
Outdated
@@ -2515,6 +2517,7 @@ | |||
{"usage": "city", "name": "New Sharon"}, | |||
{"usage": "city", "name": "New Shoreham"}, | |||
{"usage": "city", "name": "New Sweden"}, | |||
{"usage": "city", "name": "New Vegas"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are generally based on real city names - is there a New Vegas somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are generally based on real city names - is there a New Vegas somewhere?
There most likely is not. It's a reference to a classic post apocalyptic video game of the same name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep the place names to real ones, it's best we don't go down the road of allowing references in this particular context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep the place names to real ones, it's best we don't go down the road of allowing references in this particular context.
I gotcha, I'll get rid of that one.
All of the other places are real, so they should be good then.
Summary
SUMMARY: Content "Added some extra possible names"
Purpose of change
I thought of some names that I thought would go well with this game, so I added them. Nothing Major.