Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a few names to en.json #37769

Merged
merged 3 commits into from
Feb 6, 2020
Merged

Added a few names to en.json #37769

merged 3 commits into from
Feb 6, 2020

Conversation

Thomasasia
Copy link
Contributor

Summary

SUMMARY: Content "Added some extra possible names"

Purpose of change

I thought of some names that I thought would go well with this game, so I added them. Nothing Major.

@Brian-Otten
Copy link
Contributor

These seem to be normal names that can be added just fine.

@@ -2515,6 +2517,7 @@
{"usage": "city", "name": "New Sharon"},
{"usage": "city", "name": "New Shoreham"},
{"usage": "city", "name": "New Sweden"},
{"usage": "city", "name": "New Vegas"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are generally based on real city names - is there a New Vegas somewhere?

Copy link
Contributor Author

@Thomasasia Thomasasia Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are generally based on real city names - is there a New Vegas somewhere?

There most likely is not. It's a reference to a classic post apocalyptic video game of the same name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the place names to real ones, it's best we don't go down the road of allowing references in this particular context.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the place names to real ones, it's best we don't go down the road of allowing references in this particular context.

I gotcha, I'll get rid of that one.

All of the other places are real, so they should be good then.

@ZhilkinSerg ZhilkinSerg added the [JSON] Changes (can be) made in JSON label Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants