-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add looks_like for magazines #37748
Add looks_like for magazines #37748
Conversation
Less ascii showing up in the tilesets and less work for tileset makers is always good. I reviewed the code real quick so for others convenience, all the rifle type magazines are now looks like the stanag_30 and the pistol type look like glock_17. I don't know enough about what tiles are commonly missing to say if this is the best choice, but it should definitely be an okay choice. |
Looks_like for .410 mags
Besides Glock 17 and stanag 30, which item id's should I be drawing tiles for to get the most bang for my buck |
Merge pull request CleverRaven#37748 from LaVeyanFiend/Looks_Like_Mags
Summary
SUMMARY: Infrastructure "Add looks_like to vanilla magazines"
Purpose of change
Companion PR to #35361, and the recent mainlining of Ultimate Cataclysm means a lot of ASCII symbols would show up if there's no looks_like backup.
Describe the solution
Add looks_like to every magazine and speedloader, using the same whitelist as the guns. As some on those list didn't use external magazines, additional whitelist:
Explosive launchers: Mark 19's grenade belt
[X]throwers: 3L pressurized tank
Shotguns: shotshell belt
Describe alternatives you've considered
None.
Testing
Loading with Retrodays Tileset active.
![image](https://user-images.githubusercontent.com/51099123/74094578-a3714e00-4ab1-11ea-9c53-210681f13080.png)
![image](https://user-images.githubusercontent.com/51099123/74094588-c13eb300-4ab1-11ea-9b2b-3a2e3b891b04.png)
Before:
After:
Additional context