Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add looks_like to vanilla guns #35361

Merged
merged 8 commits into from Nov 7, 2019
Merged

Add looks_like to vanilla guns #35361

merged 8 commits into from Nov 7, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 6, 2019

Summary

SUMMARY: Infrastructure "Add looks_like to all vanilla guns"

Purpose of change

Start of .json work to complete #34230.

Describe the solution

Adds looks_like to all vanilla guns according to this whitelist(can't use abstracts as pointed out by anothersimulacrum):
Pistol: Glock 17
Revolver: S&W 619
Shotgun: Remington 870
SMG: H&K MP5
Rifle: AR-15
Launcher: M79
Crossbow: Crossbow(duh)
Sling/slingshots: Slingshot
Bow: Longbow

Describe alternatives you've considered

  1. Compressing pistol & revolver backups into Glock 17 for both.
  2. M134D-H Minigun as backup for turret guns + M/HMGs.
  3. M14 as backup for wood stock rifles & sniper rifles.

Testing

Hodor's Tileset:
Brace slingshot, sling, & slingshot top-to-bottom before looks_like(Brace has no texture, slingshot & sling do):
image
After, showing looks_like works & doesn't override existing textures:
image

Additional context

Future PRs will be in categories of items in vanilla before moving onto mods. Planning on food or vehicle parts next.

@ghost ghost marked this pull request as ready for review November 7, 2019 17:08
@curstwist curstwist added Items / Item Actions / Item Qualities Items and how they work and interact Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics [JSON] Changes (can be) made in JSON labels Nov 7, 2019
@ZhilkinSerg ZhilkinSerg merged commit 4e1fbf5 into CleverRaven:master Nov 7, 2019
@ghost ghost deleted the LooksLikeVanilla branch November 7, 2019 21:07
@ghost ghost mentioned this pull request Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants