Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gun barrel length to string #37738

Merged
merged 3 commits into from
Feb 6, 2020
Merged

Gun barrel length to string #37738

merged 3 commits into from
Feb 6, 2020

Conversation

snipercup
Copy link
Contributor

@snipercup snipercup commented Feb 5, 2020

Summary

SUMMARY: none

Purpose of change

Contributes to #36110. I say that because #14825 introduced the barrel_length and it shows the properties as integers. Also, the documentation (JSON_INFO.md) suggests using a string.

Describe the solution

Change barrel_length property in guns to strings. The documentation tells me '9ml per inch is a good approximation'. I assume the integers represent the amount of inches of the barrel, therefor I multiplied it by 9 ml.

Documentation suggest 9ml per inch but it should be 250 ml per inch.

Describe alternatives you've considered

Not changing

Testing

The original guns:
image

Sawn off before the change:
image

Sawn of after the change:
image

Note that the results are the same.

@ZhilkinSerg ZhilkinSerg added the [JSON] Changes (can be) made in JSON label Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants