Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Updating Legacy JSON.md #95

Closed
wants to merge 11 commits into from
Closed

Create Updating Legacy JSON.md #95

wants to merge 11 commits into from

Conversation

UmbralReaper
Copy link
Collaborator

@UmbralReaper UmbralReaper commented Jul 23, 2020

This is still a WIP, so I'm opening this as a draft PR. If I've missed anything or need to add extra information, please feel free to comment.

Please view at: https://github.com/UmbralReaper/Goats-Mod-Compilation/blob/doc-updating-JSON/Updating%20Legacy%20JSON.md

Copy link
Member

@TheGoatGod TheGoatGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i approve this lol but its not finished i can merge and edit my self

Updating Legacy JSON.md Outdated Show resolved Hide resolved
Updating Legacy JSON.md Outdated Show resolved Hide resolved
Updating Legacy JSON.md Outdated Show resolved Hide resolved
```regex
"volume": ([0-9]+)
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Atom way to find weight is:

CTRL+F entre in the top field `"weight": 1,` (all weights in the json file will show up in  light blue)

And the corresponding replace is:

entre in the top field `"weight": "250 ml",` and press replace or replace all

Because the volume value is multiplied by 250ml, replacing has to be done manually, however, to find all code to fix json files you need another software as far as I'm aware:

Top right entre the code you are looking for `"Volume": 1,` every file with this will show below drag and drop into atom

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This vaguely confuses me. Just to be clear, what you're saying in the second section of you post is that atom has a way to replace all obsolete volume values, correct?
The first section of your post is what I meant when I said, "normal find and replace".

Updating Legacy JSON.md Show resolved Hide resolved
Updating Legacy JSON.md Outdated Show resolved Hide resolved
Updating Legacy JSON.md Outdated Show resolved Hide resolved
Updating Legacy JSON.md Show resolved Hide resolved
@UmbralReaper
Copy link
Collaborator Author

UmbralReaper commented Jul 23, 2020

Thanks for the comments! I knew I missed something. As this is still a WIP, I temporarily ignored pocket data and bleed code as they are both huge messes. Artifact data needs updating as well.

@UmbralReaper
Copy link
Collaborator Author

I should have a new copy out somewhere in the next 12 hours.

@UmbralReaper
Copy link
Collaborator Author

UmbralReaper commented Jul 24, 2020

Please read under edit file -> preview changes. This shows it with all formatting properly applied.

EDIT: Please read here: https://github.com/UmbralReaper/Goats-Mod-Compilation/blob/doc-updating-JSON/Updating%20Legacy%20JSON.md

@UmbralReaper UmbralReaper requested a review from TheGoatGod July 24, 2020 10:13
Updating Legacy JSON.md Outdated Show resolved Hide resolved
@TheGoatGod
Copy link
Member

wow you have done alot of work and ill merge when your ready, i made an attempt at rights up some code but im gonna delete it yours has so much more to it, and you have confused me as well lol
image
at the bottom you see find and replace there is also regex included .* button on the lower right
i how ever punch in the code and the updated code and replace all. it takes longer like
actually im going download grepwin and see what its like, i use atom and ultrasearch because i find it easy to use, but grepwin looks alot better then ultrasearch

@UmbralReaper
Copy link
Collaborator Author

UmbralReaper commented Jul 27, 2020

Regex takes a bit longer, but I've never had a search (even through the entire mods folder) take longer than 30 seconds.

Just remember to use the 'test Regex' option before you actually replace.

@UmbralReaper UmbralReaper marked this pull request as ready for review July 27, 2020 22:33
@UmbralReaper
Copy link
Collaborator Author

This should be ready to merge - up to you @TheGoatGod

@UmbralReaper UmbralReaper changed the title [CR] [WIP] Create Updating Legacy JSON.md Create Updating Legacy JSON.md Jul 28, 2020
@UmbralReaper UmbralReaper deleted the doc-updating-JSON branch July 29, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants