Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axe ring holster #36521

Merged
merged 13 commits into from
Dec 30, 2019
Merged

Axe ring holster #36521

merged 13 commits into from
Dec 30, 2019

Conversation

NeevAsteria
Copy link
Contributor

@NeevAsteria NeevAsteria commented Dec 29, 2019

Summary

SUMMARY: Content "Adds a holster specifically for axes"

Describe the solution

Due to the lack of holster for axes and some axes not being able to be stored on some belts, I decided to make one that is similar to sheaths exclusively for axe use. Also edited axes and axe-like items to make it work with my addition

Edit 1: Also edited lumberjack profession to spawn in with one. Thanks to LaVeyanFiend for reminding me.

Testing

Checked if I can load a game, no errors. Used a debug world and spawned the materials needed to craft it, with no problems on crafting it. Tested every axe or axe-like items that I edited with the "SHEATH_AXE" flag if it can be stored, successful on all items.

Additional context

Axe ring holster samples
maxresdefault
yhst-138463016558931_2413_249131458

@ghost
Copy link

ghost commented Dec 29, 2019

Can you give the lumberjack profession the ring holster? ❤️

@NeevAsteria
Copy link
Contributor Author

Forgot about that one despite having my current character started as one. Thanks for the heads up. Added it now.

@NeevAsteria
Copy link
Contributor Author

Also made a mod version.

https://github.com/NeevAsteria/Axe-Ring-Holster-Mod

"subcategory": "CSC_ARMOR_STORAGE",
"skill_used": "tailor",
"difficulty": 4,
"skills_required": [ "melee", 1 ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if melee combat skill is really needed for crafting anything.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's what other melee holster have. Baldrics, sheaths, scabbards, and back scabbards have it so I thought I might add it as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer removing the requirement of melee skill from those recipes instead of adding it to another one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove that requirement on the other items if it's ok, tho it's kind of stepping outside my intended PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be done in a different PR, it's unrelated to this one.

Comment on lines 761 to 764
"coverage": 5,
"encumbrance": 2,
"material_thickness": 1,
"use_action": {
Copy link

@ghost ghost Dec 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file needs a linting to get the JSON validator to accept it.

@curstwist curstwist added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants