-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new tileset retrodays+ #36424
new tileset retrodays+ #36424
Conversation
Could I suggest you choose a different name, that says what is different than normal RetroDays? |
there is the + |
That doesn't say what is different, it provides no information other than that it is different. |
your request it is too vague. well, here it's "retrodays" and "retrodays+". |
For those chesthole examples, it conveys a lot of information - it's the size of the tiles. Something like transparent RetroDays suffices, try to get the core of what makes it different from normal RetroDays. |
what do you want me to do ? i have no idea. |
I'm asking that you name it something other than RetroDays+, something that tells you more about what is different than RetroDays. |
like what? |
Something like that. |
this seems more like a fix to me, otherwise maybe retroydays_rework or retrodays_improved if ur planning to add more to it |
Captn's RetroDays maybe? ) |
there is no way for me to know in advance what i will do with this tileset. |
I think it's very unclear what this tileset it to people who will be looking at changing tilesets, and lead to endless questions about what the difference is. You can change the name anytime you do something different in the future, but I think not having it as |
I think it is okay to keep it named RetroDays+ if there is intent to modify it more. |
I am not completely sure that all tiles should be transparent, but we'll see feedback from players. |
Merge pull request CleverRaven#36424 from captnblood/retrodays+
Summary
SUMMARY: Interface "new tileset based on retrodays "
Purpose of change
i wanted to add transparency to retrodays in my previous PR #36404, but i was told it would be better to make a separate tileset instead for the time being, so here it is.
a new tileset called "retrodays+" which is basically retrodays with transparency for now.
but, considering the opportunity here, i might actually enjoy modifying a bit more, here and here, widening the differences between the two of them. we'll see how it goes.
Describe the solution
in retrodays, there was a black square drawn behind all objects rendering them all 'blocky'.
they obstruct visibility, for example: a table with 4 objects on it, and the table is in practice invisible with classic retrodays.
now with "retrodays+" and transparency, we can have 4 objects on a table and still see it is there underneath the object placed on it. well, screenshots might describe this better. so for your consideration:
in general look for objects on top of bigger objects, like the tables and sofas:
![book_desc](https://user-images.githubusercontent.com/59030614/71412015-f7cc8580-264b-11ea-9059-b34633424b7a.png)
another example, look at bed and table:
![grab](https://user-images.githubusercontent.com/59030614/71413923-bd1b1b00-2654-11ea-9ce4-c0c51f90da55.png)
before:
![retrodays-before](https://user-images.githubusercontent.com/59030614/71412018-f8651c00-264b-11ea-8658-654fcdb75ce8.png)
after:
![retrodays-after](https://user-images.githubusercontent.com/59030614/71412017-f7cc8580-264b-11ea-9c1f-ee523ac909f1.png)
tiles:
![Untitled](https://user-images.githubusercontent.com/59030614/71412274-4890ae00-264d-11ea-8de0-b08d53a71d3d.png)