Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding transparency to retrodays #36404

Closed
wants to merge 1 commit into from
Closed

adding transparency to retrodays #36404

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 24, 2019

Summary

SUMMARY: Interface "add transparency to retrodays"

Purpose of change

retrodays tileset is my favourite but, all the tiles have a black background thus rendering all objects like a black square with the object drawn on that.
the problem is, when you have and object on top of a larger one, like a lighter on a table,
the lighter gfx and its black square background, prevent you to see the table underneath.
it make it look like the table is missing a whole chunk. to the point that if there is few objects (3 or 4) on the table you cannot distinguish there's a table at all.

so i removed the black squares, and left instead a black outline around the contours of the objects.
other tilesets have transparency, so i made it for retrodays too.

Describe the solution

i removed black squares around tiles, and left a black outline instead.

Testing

i have been playing with that for quite some time.

Additional context

in general look for objects on top of bigger objects, like the tables and sofas:
book_desc

another example, look at bed and table:
grab

before:
retrodays-before

after:
retrodays-after

tiles:
Untitled

@esotericist
Copy link
Contributor

I was under the impression retrodays having a black background for things was an intentional stylistic element, given the general aesthetic and the name.

Given that, this possibly should be either a separate retrodays variant or a retrodays tileset mod, rather than an alteration to the original retrodays?

@ghost
Copy link
Author

ghost commented Dec 24, 2019

@esotericist
if that's the case,
and that retrodays want to keep its black borders, then introducing a variant of it, is fine by me too.
i really like the aspect of retrodays, but i find it look even better without the black squares.
i'll let this PR sits for a while, see what people want to decide.

@ZhilkinSerg
Copy link
Contributor

@esotericist
if that's the case,
and that retrodays want to keep its black borders, then introducing a variant of it, is fine by me too.
i really like the aspect of retrodays, but i find it look even better without the black squares.
i'll let this PR sits for a while, see what people want to decide.

Make it a different tileset, we'll merge it and see players reaction.

@ghost
Copy link
Author

ghost commented Dec 25, 2019

@ZhilkinSerg
ok i close this PR and open a new, with a separate tileset made from retrodays

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants