Fix for liquid handling during butchery after interruption #36245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix for liquid handling during butchery after interruption"
Purpose of change
Fixes #35514
Describe the solution
The activity was cancelled halfway through the butcher_finish function, due to the liquid handling calling cancel_activity when interrupted, this clears the activity targets etc.
Then the rest of the function finishes, and tries to pop_back() on empty activity targets and remove the item that was a reference to activity target.
Ive made the target a non-reference, and checked for targets being non-empty before pop_back() as these things are changed during the function.
Describe alternatives you've considered
N/A
Testing
modified the code to spawn a zombie during liquid handling in butcher_finish() , this forced an interruption every time, caused a crash every time.
Now no crash.
Additional context
N/A