Crash while butchering - magiclysm

[FunkleBlaze]

Describe the bug

When butchering, in certain circumstances, game crash. In my case it involve pouring tainted blood (from magiclysm) to container.

Steps To Reproduce

1. Start butchering corpse next to container (not tested if container can be in inventory).
2. At the end of butchering, choose container to pour liquid
3. Get notification to stop pouring - in my case 'monsters spotted'.
4. Stop pouring liquid (option 'yes').
5. Choose container (chose same one).
6. Crash.

Expected behavior

Lack of crash :)

Versions and configuration

• OS: Windows 10
• Game Version: 0.D-9360-ge71ad4f
• Graphics version: MSX++DEAD_PEOPLE
• Mods loaded:
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Magiclysm [magiclysm],
  Hydroponics [hydroponics],
  Vehicle Additions Pack [blazemod],
  SpeedyDex [speedydex],
  Stats Through Kills [stats_through_kills],
  Stats Through Skills [StatsThroughSkills]

Additional context

Oakhill.zip

• note My first small pull request to README.md #1: I don't know why game give me option to choose container, in which I can dump liquid (tainted blood from zombie in my case), when I stopped pouring it.
• note Mutated flowers concept #2: In my save, you must try around 3 times to reproduce this. It depend when (and if) you get notification.
• note Add non-source files to the .gitignore #3: If you choose option 'ignore', then crash will not occur.

[Funguss]

I'm not sure this is going to be Magiclysm exclusive, it seems like it could be a problem with fluid handling from butchery at least, though possibly any fluid generation that gets interrupted and handled in this way. The furniture that generates clean water on disassembly might have the potential for the same issue. I imagine that the problem exists in that if you 'ignore' the fluid would stay in its' original container, which doesn't actually exist. You should have to choose a space on the ground to dump it.

[FunkleBlaze]

I'm not sure this is going to be Magiclysm exclusive, it seems like it could be a problem with fluid handling from butchery at least, though possibly any fluid generation that gets interrupted and handled in this way. The furniture that generates clean water on disassembly might have the potential for the same issue. I imagine that the problem exists in that if you 'ignore' the fluid would stay in its' original container, which doesn't actually exist. You should have to choose a space on the ground to dump it.

Normally, I just clear entire area before I start butchering, but sometimes I forget about it.

[FunkleBlaze]

Pouring on to ground (in step 5) also will end with crash. You can choose pouring to ground if instead of choosing container, you press 'esc'

[ghost]

I cannot get this to happen, nothing interrupts the pouring of the liquid.

[MEXAHOTABOP]

this just happens sometime especially when you clean city by own hands

now i just disable blood in my build because zombie blood almost useless anyway and used only by one questionable CBM and one scroll where this is not mandatory
just one big waste of time when butcher zombies at my point of view

[KorGgenT]

I've not been able to time it so i can get interrupted in the middle of pouring. is there a way you're doing it that you can force the notification or time it with a monster being spotted, or are you just randomly butchering in the middle of a town?

[FunkleBlaze]

I've not been able to time it so i can get interrupted in the middle of pouring. is there a way you're doing it that you can force the notification or time it with a monster being spotted, or are you just randomly butchering in the middle of a town?

I wasn't playing for a while, but I was butchering after killing every few zombies. Crashes were when sth hostile spotted me and was coming at me.

[KorGgenT]

call stack in visual studio:

>	Cataclysm-vcpkg-static-Release-x64.exe!item_location::remove_item() Line 600	C++
 	Cataclysm-vcpkg-static-Release-x64.exe!activity_handlers::butcher_finish(player_activity * act, player * p) Line 1273	C++
 	[Inline Frame] Cataclysm-vcpkg-static-Release-x64.exe!std::_Func_class<void,player_activity *,player *>::operator()(player_activity * <_Args_0>, player * <_Args_1>) Line 119	C++
 	Cataclysm-vcpkg-static-Release-x64.exe!activity_type::call_finish(player_activity * act, player * p) Line 122	C++
 	Cataclysm-vcpkg-static-Release-x64.exe!player_activity::do_turn(player & p) Line 183	C++
 	Cataclysm-vcpkg-static-Release-x64.exe!game::process_activity() Line 1636	C++
 	Cataclysm-vcpkg-static-Release-x64.exe!game::do_turn() Line 1407	C++
 	Cataclysm-vcpkg-static-Release-x64.exe!WinMain(HINSTANCE__ * __formal, HINSTANCE__ * __formal, char * __formal, int __formal) Line 688	C++

[KorGgenT]

i have narrowed it down to this:
in butcher_finish(), the call to butchery_drops_harvest() somehow empties the targets vector. once this happens, it either invalidates the item_location which causes a crash in ptr->valid(), or it causes a crash in targets.pop_back() because targets is empty.
it's pretty annoying to reproduce because it's based on timing and rng, and you just have to hope you get interrupted after you finish butchering but before you pour the liquid from the butchery.