Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions for all the Free Merchant NPC missions. #33325

Merged

Conversation

Petethegoat
Copy link
Contributor

Summary

SUMMARY: Content "Add mission descriptions for Free Merchant faction missions, and fix the two jar-related missions."

Purpose of change

Utilize the new functional mission descriptions (from #32778) to make sure relevant information (eg. rewards 💵) is available to the player after they exit dialogue.

While I was there, I adjusted some of the names for variety, and fixed the last two FMC missions being uncompletable because they were looking for non-existent item groups instead of items.
Also migrated the cigarette mission definition into the guard's json file.

Additional Context

Against my better judgement, I did not adjust the pitiful rewards. 25 merch for 100 god damn jars. 😡

…hopkeeper, broker, and cig guard.

Migrate the cigarette mission into the guard's file.
@Petethegoat Petethegoat changed the title Add descriptions for all the Free Merchant NPC missions. Covers the s… Add descriptions for all the Free Merchant NPC missions. Aug 18, 2019
@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Missions Quests and missions labels Aug 18, 2019
@Night-Pryanik
Copy link
Contributor

I think there's no need in mentioning exact number of merch in mission descriptions because if we want to balance their amount somewhere in the future, we would need to update the descriptions too instead of updating only the u_buy_item field.

@ZhilkinSerg
Copy link
Contributor

I think there's no need in mentioning exact number of merch in mission descriptions because if we want to balance their amount somewhere in the future, we would need to update the descriptions too instead of updating only the u_buy_item field.

I agree. And it would be nice to implement some string tokens usable in text to display values of mission parameters dynamically.

@Petethegoat
Copy link
Contributor Author

Agreed. I'll look into adding some tokens to show that dynamically, and if that's too hard I'll just remove the amounts.

@kevingranade kevingranade merged commit 406dd4d into CleverRaven:master Aug 21, 2019
@Petethegoat Petethegoat deleted the mission-descriptions-freemerchants branch August 21, 2019 05:06
misterprimus pushed a commit to misterprimus/Cataclysm-DDA that referenced this pull request Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Missions Quests and missions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants