Load and display mission descriptions. #32778
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Quest descriptions will now be loaded and used correctly."
Purpose of change
Resolve #30848 - I think it's agreed that programmatically displaying the literal quest requirements isn't necessary or particularly desirable (no need to draw attention to the relatively low variety of mission objectives)
Describe the solution
Add a description field to the
mission_type
struct, and actually load the description from the json definition. Pass the description to the mission itself when it's created.While I'm fixing things, improve the display so it handles wrapping correctly.
Note that this doesn't actually add any descriptions. An example is below, but it's very simple.
Describe alternatives you've considered
Totally redoing the mission front and backend. Maybe later.
Additional context
Demonstration of multiline wrapping etc working nice. Can use a 😎 cool, undescriptive quest name, and rely on the description to tell players what to actually do.
![example mission description](https://user-images.githubusercontent.com/734762/62173551-27c16800-b2fc-11e9-8552-c29d704e3a5c.png)
Edited:
I've applied a nicer quick fix, thanks ralree- but it should be more than adequate for now, until someone wants to look into some deeper refactor and cleanup for mission serialization.