Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebalance item handling costs #14977

Merged
merged 17 commits into from
Jan 28, 2016
Merged

Rebalance item handling costs #14977

merged 17 commits into from
Jan 28, 2016

Conversation

mugling
Copy link
Contributor

@mugling mugling commented Jan 24, 2016

Continues from #14972 (which adds ammo pouches and some new constants) by adding a single extra commit (24e5c39) that improves the balance of item handling.

  • increases the overall cost by 100% (VOLUME_MOVE_COST)
  • increase the cost of items not worn or in holsters by a further 50% (MAP_HANDLING_FACTOR)
  • reduces the minimum handling cost by 25% to 30 (MIN_HANDLING_COST)

The idea is that holsters are currently too cheap (#14306) so the overall effect is to increase their cost whilst keeping their advantage of fetching items from the inventory.

@mugling mugling changed the title Rebalance moves Rebalance item handling costs Jan 24, 2016
mugling added 17 commits January 24, 2016 01:29
@mugling
Change reference to pointer *::in visit_items
cd47ee0
@mugling
Extend visitor pattern to provide parent node
a5e8d48
@mugling
Implement Character::find_parent()
3122ce7
@mugling
Implement inventory::find_parent()
2d4d352
@mugling
Implement item::find_parent()
afe421f
@mugling
Implement item_location::describe()
2653b32
@mugling
Add handling factor constants
6942079 
* INVENTORY_HANDLING_FACTOR
* MAP_HANDLING_FACTOR
* VEHICLE_HANDLING_FACTOR
@mugling
Add option to can_holster to ignore contained items
31d72f6
@mugling
Implement item_location::obtain()
9c139a2
@mugling
Further document item_location::remove_item()
e365cd9
@mugling
Describe location in item::pick_reload_ammo()
edf7d80
@mugling
Use item_location::obtain() when reloading
5190258
@mugling
item::pick_reload_ammo() selects from adjacent tiles
f8a0fdc
@mugling
Add leg ammo pouch as new item
bbd5d4e
@mugling
Add COMPACT_MAG flag to magazines
084c006
@mugling
Document COMPACT_MAG and BULKY_MAG
4842355
@mugling
Rebalance item handling costs
24e5c39
@kevingranade kevingranade merged commit 24e5c39 into CleverRaven:master Jan 28, 2016
@mugling mugling mentioned this pull request Jan 29, 2016
Merged
@mugling mugling deleted the rebalance_moves branch January 31, 2016 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mugling @kevingranade