Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earthshaper becomes Technomancer by installing Crystallized Mana Nose CBM #47965

Closed
wapcaplet opened this issue Mar 10, 2021 · 3 comments · Fixed by #53810
Closed

Earthshaper becomes Technomancer by installing Crystallized Mana Nose CBM #47965

wapcaplet opened this issue Mar 10, 2021 · 3 comments · Fixed by #53810
Labels
Bionics CBM (Compact Bionic Modules) <Bug> This needs to be fixed Mods: Magiclysm Anything to do with the Magiclysm mod

Comments

@wapcaplet
Copy link
Contributor

Describe the bug

When a character has the Earthshaper trait (and is locked out of the Technomancer class), they can become a Technomancer simply by installing the Crystallized Mana Nose CBM.

Steps To Reproduce

  1. Learn an Earthshaper spell, and accept the prompt to become locked out of Technomancer class
  2. Get a Crystallized Mana Nose CBM and some anesthetic
  3. Find or map-edit in an Autodoc and couch
  4. Use the autodoc to install the CBM, and accept the prompt to lose the Earthshaper trait

Expected behavior

Converting from Earthshaper to Technomancer should not be possible.

If the character has the Earthshaper class already, they should not be able to attempt a Technomancer CBM installation at all.

Screenshots

Prompt warns that Earthshaper trait will be removed, but no mention that Technomancer will be forced upon them:

image

Message log shows Earthshaper spells being forgotten, and class changing:

image

Versions and configuration

  • OS: Linux
    • OS Version: Distributor ID: Pop; Description: Pop!_OS 20.04 LTS; Release: 20.04; Codename: focal;
  • Game Version: 0.E-9956-gf6f104a441-dirty [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Bionic Professions [package_bionic_professions],
    Magiclysm [magiclysm]
    ]

Additional context

Found by Ungen on Discord

@wapcaplet wapcaplet added <Bug> This needs to be fixed Bionics CBM (Compact Bionic Modules) Mods: Magiclysm Anything to do with the Magiclysm mod labels Mar 10, 2021
@anothersimulacrum
Copy link
Member

#47822 probably does what this wants.

@Maleclypse
Copy link
Member

Can this be closed or does someone need to make some changes using json from #47822 to finalize this?

@wapcaplet
Copy link
Contributor Author

wapcaplet commented Dec 27, 2021

Stil reproducible. Changing "canceled_mutations" to "mutation_conflicts" for the CBM, per the linked PR, does prevent installing the Nose CBM:

image

Patch submitted at #53810

  • OS: Linux
    • OS Version: Distributor ID: Pop; Description: Pop!_OS 20.04 LTS; Release: 20.04; Codename: focal;
  • Game Version: 0.F-4600-gb5228cfae9 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions],
    Magiclysm [magiclysm]
    ]

wapcaplet added a commit to wapcaplet/Cataclysm-DDA that referenced this issue Dec 27, 2021
akrieger pushed a commit to akrieger/Cataclysm-DDA that referenced this issue Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bionics CBM (Compact Bionic Modules) <Bug> This needs to be fixed Mods: Magiclysm Anything to do with the Magiclysm mod
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants