-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub runners for Windows 2022 #1208
Conversation
3a8c8ce
to
388bc4b
Compare
3f613a5
to
5f37361
Compare
aa8a792
to
dd11fa5
Compare
🎉 ... this appears to work (at least for MSVC 14.3). Regarding MSVC 14.0 (which compiles on my local machine for VS 2022), here is a relevant snippet from the complete build logs
(see failed build log) Fwiw, on a local windows installation with MSVC 14.0 through 14.3 installed, SCons detects
|
d6691a4
to
49c36d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this as well! Disappointing that windows-2016
has to be dropped and we can't test MSVC 14.1, but oh well!
76e61e2
to
96ad7c9
Compare
59fda14
to
9797256
Compare
1798a22
to
b92cdba
Compare
7bf4194
to
0688afe
Compare
0688afe
to
8b28d83
Compare
@bryanwweber ... I think this is finally ready! |
Changes proposed in this pull request
windows-2016
towindows-2022
conda
driven compilation environmentwindows-2019
without changesscons install
inconda
-based runnersIf applicable, fill in the issue number this pull request is fixing
Closes #1199
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build
&scons test
) and unit tests address code coverageOther
#1192 prevents some tests forconda
-based installations on windows.