Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for covered configuration options #177

Closed
ischoegl opened this issue Mar 3, 2022 · 4 comments
Closed

Add documentation for covered configuration options #177

ischoegl opened this issue Mar 3, 2022 · 4 comments
Labels
documentation-update An update is needed to the documentation

Comments

@ischoegl
Copy link
Member

ischoegl commented Mar 3, 2022

The new GitHub CI covers a few common configuration options for a compilation of Cantera from source. It would be good to document what is routinely tested, and what is not covered by the test runners.

Issue is opened in response to discussion in Cantera/cantera#1208

@ischoegl ischoegl added the documentation-update An update is needed to the documentation label Mar 3, 2022
@speth
Copy link
Member

speth commented Mar 13, 2022

For this, were you thinking about which options to scons are covered by the CI tests, which versions of various dependencies are covered, or, I suppose, both?

There's at least an attempt at documenting the tested versions of dependencies on https://cantera.org/compiling/dependencies.html#sec-dependencies, though that is always kind of a challenge to keep updated.

@bryanwweber
Copy link
Member

This issue was opened specifically to document that MSVC 12.0 (VS 2013) is not tested, although it will likely work. So I think the intention is to document dependency versions. I think trying to document which SCons options are tested isn't as useful for users, although having some code coverage on the SCons scripts would be useful for developers...

@ischoegl
Copy link
Member Author

For this, were you thinking about which options to scons are covered by the CI tests, which versions of various dependencies are covered, or, I suppose, both?

Both. It’s probably something where finding the right layout will go a long way, as I think documenting what is tested on what platform is also interesting to users. I had admittedly forgotten about that page, but it also isn’t exactly what @bryanwweber was asking about when this came up.

@ischoegl
Copy link
Member Author

ischoegl commented May 9, 2022

Closing - this is probably not a priority, especially as keeping this updated is an unnecessary chore.

@ischoegl ischoegl closed this as completed May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation-update An update is needed to the documentation
Projects
None yet
Development

No branches or pull requests

3 participants