added sort to group directional so that correct representative UMI is… #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… selected. Tested by comparing outputs minus the corrected UMI (BX tag in sam, 6th column in tsv). Thus the UG is the same even if the BX is different. Have replaced tests
|
Would you like me to update the py3 tests? |
|
I completely forgot that python3 had separete tests. If you don't mind that would be great - I don't currently have a py3 environment to hand. |
|
No worries. I'll do this tomorrow afternoon and then merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… selected. Tested by comparing outputs minus the corrected UMI (BX tag in sam, 6th column in tsv). Thus the UG is the same even if the BX is different. Have replaced tests