Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Migrate Image component from Simorgh #225

Merged
merged 12 commits into from
Dec 19, 2018
Merged

Migrate Image component from Simorgh #225

merged 12 commits into from
Dec 19, 2018

Conversation

dr3
Copy link
Contributor

@dr3 dr3 commented Dec 18, 2018 •
edited
Loading

Resolves #203

Create initial psammead-image

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@dr3 dr3 self-assigned this Dec 18, 2018
@radiocontrolled radiocontrolled mentioned this pull request Dec 18, 2018
Merged
2 tasks
@dr3 dr3 changed the title Create initial psammead-image Migrate Image component from Simorgh Dec 18, 2018
@ChrisBAshton
Update packages/components/psammead-image/README.md
3c3c6d3 
Co-Authored-By: dr3 <drew.mcmillan@bbc.co.uk>
ChrisBAshton
ChrisBAshton previously approved these changes Dec 18, 2018
View reviewed changes
bcmn
bcmn reviewed Dec 18, 2018
View reviewed changes
Copy link
Contributor

@bcmn bcmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple wording suggestions.

packages/components/psammead-image/README.md Outdated Show resolved Hide resolved
packages/components/psammead-image/README.md Outdated Show resolved Hide resolved
@bcmn
Update packages/components/psammead-image/README.md
9132a73 
Co-Authored-By: dr3 <drew.mcmillan@bbc.co.uk>
@bcmn
Update packages/components/psammead-image/README.md
aa9246d 
Co-Authored-By: dr3 <drew.mcmillan@bbc.co.uk>
bcmn
bcmn previously approved these changes Dec 18, 2018
View reviewed changes
ChrisBAshton
ChrisBAshton previously approved these changes Dec 18, 2018
View reviewed changes
sareh
sareh previously requested changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@sareh sareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:

packages/components/psammead-image/src/index.jsx Outdated Show resolved Hide resolved
@dr3 dr3 dismissed stale reviews from ChrisBAshton and bcmn via fdcc99a December 18, 2018 12:45
ChrisBAshton
ChrisBAshton previously approved these changes Dec 18, 2018
View reviewed changes
radiocontrolled
radiocontrolled previously requested changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@radiocontrolled radiocontrolled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny change to the readme requested for consistency.

@ChrisBAshton ChrisBAshton self-assigned this Dec 18, 2018
@ChrisBAshton ChrisBAshton dismissed sareh’s stale review December 18, 2018 16:52

Issues addressed

@jamesbrumpton
Copy link
Contributor

LGTM

@sareh sareh merged commit 7bd0a97 into latest Dec 19, 2018
@sareh sareh deleted the psammead-image branch December 19, 2018 10:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sareh sareh sareh approved these changes

@ChrisBAshton ChrisBAshton ChrisBAshton approved these changes

@radiocontrolled radiocontrolled radiocontrolled left review comments

@bcmn bcmn bcmn left review comments

Assignees

@ChrisBAshton ChrisBAshton

@dr3 dr3

Labels
high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dr3 @jamesbrumpton @radiocontrolled @sareh @ChrisBAshton @bcmn